Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: Source/devtools/front_end/ui/Toolbar.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/ui/SplitWidget.js ('k') | Source/devtools/front_end/ui/Tooltip.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 911 matching lines...) Expand 10 before | Expand all | Expand 10 after
922 * @param {string} text 922 * @param {string} text
923 * @param {string=} title 923 * @param {string=} title
924 * @param {!WebInspector.Setting=} setting 924 * @param {!WebInspector.Setting=} setting
925 */ 925 */
926 WebInspector.ToolbarCheckbox = function(text, title, setting) 926 WebInspector.ToolbarCheckbox = function(text, title, setting)
927 { 927 {
928 WebInspector.ToolbarItem.call(this, createCheckboxLabel(text)); 928 WebInspector.ToolbarItem.call(this, createCheckboxLabel(text));
929 this.element.classList.add("checkbox"); 929 this.element.classList.add("checkbox");
930 this.inputElement = this.element.checkboxElement; 930 this.inputElement = this.element.checkboxElement;
931 if (title) 931 if (title)
932 WebInspector.Tooltip.install(this.element, title); 932 this.element.title = title;
933 if (setting) 933 if (setting)
934 WebInspector.SettingsUI.bindCheckbox(this.inputElement, setting); 934 WebInspector.SettingsUI.bindCheckbox(this.inputElement, setting);
935 } 935 }
936 936
937 WebInspector.ToolbarCheckbox.prototype = { 937 WebInspector.ToolbarCheckbox.prototype = {
938 /** 938 /**
939 * @return {boolean} 939 * @return {boolean}
940 */ 940 */
941 checked: function() 941 checked: function()
942 { 942 {
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 for (var i = 0; i < items.length; ++i) { 1017 for (var i = 0; i < items.length; ++i) {
1018 var item = items[i]; 1018 var item = items[i];
1019 if (item) 1019 if (item)
1020 this.appendToolbarItem(item); 1020 this.appendToolbarItem(item);
1021 } 1021 }
1022 } 1022 }
1023 }, 1023 },
1024 1024
1025 __proto__: WebInspector.Toolbar.prototype 1025 __proto__: WebInspector.Toolbar.prototype
1026 } 1026 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ui/SplitWidget.js ('k') | Source/devtools/front_end/ui/Tooltip.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698