Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/devtools/front_end/ui/SettingsUI.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SplitWidget.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 23 matching lines...) Expand all
34 * @param {string} name 34 * @param {string} name
35 * @param {!WebInspector.Setting} setting 35 * @param {!WebInspector.Setting} setting
36 * @param {boolean=} omitParagraphElement 36 * @param {boolean=} omitParagraphElement
37 * @param {string=} tooltip 37 * @param {string=} tooltip
38 * @return {!Element} 38 * @return {!Element}
39 */ 39 */
40 WebInspector.SettingsUI.createSettingCheckbox = function(name, setting, omitPara graphElement, tooltip) 40 WebInspector.SettingsUI.createSettingCheckbox = function(name, setting, omitPara graphElement, tooltip)
41 { 41 {
42 var label = createCheckboxLabel(name); 42 var label = createCheckboxLabel(name);
43 if (tooltip) 43 if (tooltip)
44 WebInspector.Tooltip.install(label, tooltip); 44 label.title = tooltip;
45 45
46 var input = label.checkboxElement; 46 var input = label.checkboxElement;
47 input.name = name; 47 input.name = name;
48 WebInspector.SettingsUI.bindCheckbox(input, setting); 48 WebInspector.SettingsUI.bindCheckbox(input, setting);
49 49
50 if (omitParagraphElement) 50 if (omitParagraphElement)
51 return label; 51 return label;
52 52
53 var p = createElement("p"); 53 var p = createElement("p");
54 p.appendChild(label); 54 p.appendChild(label);
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 WebInspector.SettingUI = function() 278 WebInspector.SettingUI = function()
279 { 279 {
280 } 280 }
281 281
282 WebInspector.SettingUI.prototype = { 282 WebInspector.SettingUI.prototype = {
283 /** 283 /**
284 * @return {?Element} 284 * @return {?Element}
285 */ 285 */
286 settingElement: function() { } 286 settingElement: function() { }
287 } 287 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SplitWidget.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698