Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: Source/devtools/front_end/emulation/ResponsiveDesignView.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @implements {WebInspector.OverridesSupport.PageResizer} 8 * @implements {WebInspector.OverridesSupport.PageResizer}
9 * @implements {WebInspector.TargetManager.Observer} 9 * @implements {WebInspector.TargetManager.Observer}
10 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder 10 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 this._pageContainerImage.addEventListener("error", this._onPageContainer ImageLoaded.bind(this, false), false); 88 this._pageContainerImage.addEventListener("error", this._onPageContainer ImageLoaded.bind(this, false), false);
89 89
90 // Page scale controls. 90 // Page scale controls.
91 this._pageScaleContainer = this._canvasContainer.element.createChild("di v", "hbox responsive-design-page-scale-container"); 91 this._pageScaleContainer = this._canvasContainer.element.createChild("di v", "hbox responsive-design-page-scale-container");
92 this._decreasePageScaleButton = this._pageScaleContainer.createChild("bu tton", "responsive-design-page-scale-button responsive-design-page-scale-decreas e"); 92 this._decreasePageScaleButton = this._pageScaleContainer.createChild("bu tton", "responsive-design-page-scale-button responsive-design-page-scale-decreas e");
93 this._decreasePageScaleButton.createChild("div", "glyph"); 93 this._decreasePageScaleButton.createChild("div", "glyph");
94 this._decreasePageScaleButton.tabIndex = -1; 94 this._decreasePageScaleButton.tabIndex = -1;
95 this._decreasePageScaleButton.addEventListener("click", this._pageScaleB uttonClicked.bind(this, false), false); 95 this._decreasePageScaleButton.addEventListener("click", this._pageScaleB uttonClicked.bind(this, false), false);
96 96
97 this._pageScaleLabel = this._pageScaleContainer.createChild("label", "re sponsive-design-page-scale-label"); 97 this._pageScaleLabel = this._pageScaleContainer.createChild("label", "re sponsive-design-page-scale-label");
98 WebInspector.Tooltip.install(this._pageScaleLabel, WebInspector.UIString ("Shift + drag to change page scale")); 98 this._pageScaleLabel.title = WebInspector.UIString("Shift + drag to chan ge page scale");
99 this._pageScaleLabel.addEventListener("dblclick", this._resetPageScale.b ind(this), false); 99 this._pageScaleLabel.addEventListener("dblclick", this._resetPageScale.b ind(this), false);
100 100
101 this._increasePageScaleButton = this._pageScaleContainer.createChild("bu tton", "responsive-design-page-scale-button responsive-design-page-scale-increas e"); 101 this._increasePageScaleButton = this._pageScaleContainer.createChild("bu tton", "responsive-design-page-scale-button responsive-design-page-scale-increas e");
102 this._increasePageScaleButton.tabIndex = -1; 102 this._increasePageScaleButton.tabIndex = -1;
103 this._increasePageScaleButton.createChild("div", "glyph"); 103 this._increasePageScaleButton.createChild("div", "glyph");
104 this._increasePageScaleButton.addEventListener("click", this._pageScaleB uttonClicked.bind(this, true), false); 104 this._increasePageScaleButton.addEventListener("click", this._pageScaleB uttonClicked.bind(this, true), false);
105 105
106 this._mediaInspector.addEventListener(WebInspector.MediaQueryInspector.E vents.CountUpdated, this._updateMediaQueryInspectorButton, this); 106 this._mediaInspector.addEventListener(WebInspector.MediaQueryInspector.E vents.CountUpdated, this._updateMediaQueryInspectorButton, this);
107 this._mediaInspector.addEventListener(WebInspector.MediaQueryInspector.E vents.HeightUpdated, this.onResize, this); 107 this._mediaInspector.addEventListener(WebInspector.MediaQueryInspector.E vents.HeightUpdated, this.onResize, this);
108 this._overridesWarningUpdated(); 108 this._overridesWarningUpdated();
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 532
533 var canvasInvalidated = viewportChanged || this._drawContentsSize !== th is._cachedDrawContentsSize || this._cachedScale !== this._scale || 533 var canvasInvalidated = viewportChanged || this._drawContentsSize !== th is._cachedDrawContentsSize || this._cachedScale !== this._scale ||
534 this._cachedCssCanvasWidth !== cssCanvasWidth || this._cachedCssCanv asHeight !== cssCanvasHeight || this._cachedZoomFactor !== zoomFactor || 534 this._cachedCssCanvasWidth !== cssCanvasWidth || this._cachedCssCanv asHeight !== cssCanvasHeight || this._cachedZoomFactor !== zoomFactor ||
535 this._cachedMediaInspectorHeight !== mediaInspectorHeight; 535 this._cachedMediaInspectorHeight !== mediaInspectorHeight;
536 536
537 if (canvasInvalidated) 537 if (canvasInvalidated)
538 this._drawCanvas(cssCanvasWidth, cssCanvasHeight, rulerTotalHeight); 538 this._drawCanvas(cssCanvasWidth, cssCanvasHeight, rulerTotalHeight);
539 539
540 if (viewportChanged) { 540 if (viewportChanged) {
541 this._pageScaleLabel.textContent = WebInspector.UIString("%.1f", thi s._viewport.pageScaleFactor); 541 this._pageScaleLabel.textContent = WebInspector.UIString("%.1f", thi s._viewport.pageScaleFactor);
542 WebInspector.Tooltip.install(this._decreasePageScaleButton, WebInspe ctor.UIString("Scale down (minimum %.1f)", this._viewport.minimumPageScaleFactor )); 542 this._decreasePageScaleButton.title = WebInspector.UIString("Scale d own (minimum %.1f)", this._viewport.minimumPageScaleFactor);
543 this._decreasePageScaleButton.disabled = this._viewport.pageScaleFac tor <= this._viewport.minimumPageScaleFactor; 543 this._decreasePageScaleButton.disabled = this._viewport.pageScaleFac tor <= this._viewport.minimumPageScaleFactor;
544 WebInspector.Tooltip.install(this._increasePageScaleButton, WebInspe ctor.UIString("Scale up (maximum %.1f)", this._viewport.maximumPageScaleFactor)) ; 544 this._increasePageScaleButton.title = WebInspector.UIString("Scale u p (maximum %.1f)", this._viewport.maximumPageScaleFactor);
545 this._increasePageScaleButton.disabled = this._viewport.pageScaleFac tor >= this._viewport.maximumPageScaleFactor; 545 this._increasePageScaleButton.disabled = this._viewport.pageScaleFac tor >= this._viewport.maximumPageScaleFactor;
546 } 546 }
547 547
548 this._cachedScale = this._scale; 548 this._cachedScale = this._scale;
549 this._cachedCssCanvasWidth = cssCanvasWidth; 549 this._cachedCssCanvasWidth = cssCanvasWidth;
550 this._cachedCssCanvasHeight = cssCanvasHeight; 550 this._cachedCssCanvasHeight = cssCanvasHeight;
551 this._cachedCssHeight = cssHeight; 551 this._cachedCssHeight = cssHeight;
552 this._cachedCssWidth = cssWidth; 552 this._cachedCssWidth = cssWidth;
553 this._cachedDeviceInsets = deviceInsets; 553 this._cachedDeviceInsets = deviceInsets;
554 this._cachedZoomFactor = zoomFactor; 554 this._cachedZoomFactor = zoomFactor;
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 { 600 {
601 this._toolbarElement = this._responsiveDesignContainer.element.createChi ld("div", "responsive-design-toolbar"); 601 this._toolbarElement = this._responsiveDesignContainer.element.createChi ld("div", "responsive-design-toolbar");
602 this._createButtonsSection(); 602 this._createButtonsSection();
603 this._createDeviceSection(); 603 this._createDeviceSection();
604 this._toolbarElement.createChild("div", "responsive-design-separator"); 604 this._toolbarElement.createChild("div", "responsive-design-separator");
605 this._createNetworkSection(); 605 this._createNetworkSection();
606 this._toolbarElement.createChild("div", "responsive-design-separator"); 606 this._toolbarElement.createChild("div", "responsive-design-separator");
607 607
608 var moreButtonContainer = this._toolbarElement.createChild("div", "respo nsive-design-more-button-container"); 608 var moreButtonContainer = this._toolbarElement.createChild("div", "respo nsive-design-more-button-container");
609 var moreButton = moreButtonContainer.createChild("button", "responsive-d esign-more-button"); 609 var moreButton = moreButtonContainer.createChild("button", "responsive-d esign-more-button");
610 WebInspector.Tooltip.install(moreButton, WebInspector.UIString("More ove rrides")); 610 moreButton.title = WebInspector.UIString("More overrides");
611 moreButton.addEventListener("click", this._showEmulationInDrawer.bind(th is), false); 611 moreButton.addEventListener("click", this._showEmulationInDrawer.bind(th is), false);
612 moreButton.textContent = "\u2026"; 612 moreButton.textContent = "\u2026";
613 }, 613 },
614 614
615 _createButtonsSection: function() 615 _createButtonsSection: function()
616 { 616 {
617 var buttonsToolbar = new WebInspector.Toolbar(this._toolbarElement); 617 var buttonsToolbar = new WebInspector.Toolbar(this._toolbarElement);
618 buttonsToolbar.makeVertical(); 618 buttonsToolbar.makeVertical();
619 buttonsToolbar.setColor("white"); 619 buttonsToolbar.setColor("white");
620 buttonsToolbar.setToggledColor("rgb(105, 194, 236)"); 620 buttonsToolbar.setToggledColor("rgb(105, 194, 236)");
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 resolutionFieldset.createTextChild("\u00D7"); 665 resolutionFieldset.createTextChild("\u00D7");
666 resolutionFieldset.appendChild(WebInspector.SettingsUI.createSettingInpu tField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UISt ring("\u2013"))); 666 resolutionFieldset.appendChild(WebInspector.SettingsUI.createSettingInpu tField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "3em", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UISt ring("\u2013")));
667 667
668 // Device pixel ratio. 668 // Device pixel ratio.
669 detailsElement.createChild("div", "responsive-design-suite-separator"); 669 detailsElement.createChild("div", "responsive-design-suite-separator");
670 670
671 var dprElement = detailsElement.createChild("div", ""); 671 var dprElement = detailsElement.createChild("div", "");
672 var resolutionFieldset2 = WebInspector.SettingsUI.createSettingFieldset( WebInspector.overridesSupport.settings.emulateResolution); 672 var resolutionFieldset2 = WebInspector.SettingsUI.createSettingFieldset( WebInspector.overridesSupport.settings.emulateResolution);
673 dprElement.appendChild(resolutionFieldset2); 673 dprElement.appendChild(resolutionFieldset2);
674 var dprButton = resolutionFieldset2.createChild("div", "responsive-desig n-icon responsive-design-icon-dpr"); 674 var dprButton = resolutionFieldset2.createChild("div", "responsive-desig n-icon responsive-design-icon-dpr");
675 WebInspector.Tooltip.install(dprButton, WebInspector.UIString("Device pi xel ratio")); 675 dprButton.title = WebInspector.UIString("Device pixel ratio");
676 resolutionFieldset2.appendChild(WebInspector.SettingsUI.createSettingInp utField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, " 1.9em", WebInspector.OverridesSupport.deviceScaleFactorValidator, true, true, We bInspector.UIString("\u2013"))); 676 resolutionFieldset2.appendChild(WebInspector.SettingsUI.createSettingInp utField("", WebInspector.overridesSupport.settings.deviceScaleFactor, true, 4, " 1.9em", WebInspector.OverridesSupport.deviceScaleFactorValidator, true, true, We bInspector.UIString("\u2013")));
677 677
678 // Fit to window. 678 // Fit to window.
679 detailsElement.createChild("div", "responsive-design-suite-separator"); 679 detailsElement.createChild("div", "responsive-design-suite-separator");
680 var fitToWindowElement = detailsElement.createChild("div", ""); 680 var fitToWindowElement = detailsElement.createChild("div", "");
681 fieldsetElement = fitToWindowElement.createChild("fieldset"); 681 fieldsetElement = fitToWindowElement.createChild("fieldset");
682 var fitCheckbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspe ctor.UIString("Zoom to fit"), WebInspector.overridesSupport.settings.deviceFitWi ndow, true, WebInspector.UIString("Zoom to fit available space")) 682 var fitCheckbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspe ctor.UIString("Zoom to fit"), WebInspector.overridesSupport.settings.deviceFitWi ndow, true, WebInspector.UIString("Zoom to fit available space"))
683 fieldsetElement.appendChild(fitCheckbox); 683 fieldsetElement.appendChild(fitCheckbox);
684 themeCheckbox(fitCheckbox); 684 themeCheckbox(fitCheckbox);
685 685
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 WebInspector.EmulationDispatcher.prototype = { 853 WebInspector.EmulationDispatcher.prototype = {
854 /** 854 /**
855 * @override 855 * @override
856 * @param {!EmulationAgent.Viewport=} viewport 856 * @param {!EmulationAgent.Viewport=} viewport
857 */ 857 */
858 viewportChanged: function(viewport) 858 viewportChanged: function(viewport)
859 { 859 {
860 this._responsiveDesignView._viewportChanged(viewport); 860 this._responsiveDesignView._viewportChanged(viewport);
861 } 861 }
862 } 862 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesView.js ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698