Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: Source/devtools/front_end/emulation/OverridesView.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField ("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebIns pector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString(" \u2013")); 218 var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField ("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebIns pector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString(" \u2013"));
219 cellElement.appendChild(widthOverrideInput); 219 cellElement.appendChild(widthOverrideInput);
220 var heightOverrideInput = WebInspector.SettingsUI.createSettingInputFiel d("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebI nspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString ("\u2013")); 220 var heightOverrideInput = WebInspector.SettingsUI.createSettingInputFiel d("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebI nspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString ("\u2013"));
221 cellElement.appendChild(heightOverrideInput); 221 cellElement.appendChild(heightOverrideInput);
222 222
223 rowElement = tableElement.createChild("tr"); 223 rowElement = tableElement.createChild("tr");
224 cellElement = rowElement.createChild("td"); 224 cellElement = rowElement.createChild("td");
225 cellElement.colSpan = 4; 225 cellElement.colSpan = 4;
226 226
227 rowElement = tableElement.createChild("tr"); 227 rowElement = tableElement.createChild("tr");
228 WebInspector.Tooltip.install(rowElement, WebInspector.UIString("Ratio be tween a device's physical pixels and device-independent pixels")); 228 rowElement.title = WebInspector.UIString("Ratio between a device's physi cal pixels and device-independent pixels");
229 rowElement.createChild("td").createTextChild(WebInspector.UIString("Devi ce pixel ratio:")); 229 rowElement.createChild("td").createTextChild(WebInspector.UIString("Devi ce pixel ratio:"));
230 rowElement.createChild("td").appendChild(WebInspector.SettingsUI.createS ettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, t rue, 4, "80px", WebInspector.OverridesSupport.deviceScaleFactorValidator, true, true, WebInspector.UIString("\u2013"))); 230 rowElement.createChild("td").appendChild(WebInspector.SettingsUI.createS ettingInputField("", WebInspector.overridesSupport.settings.deviceScaleFactor, t rue, 4, "80px", WebInspector.OverridesSupport.deviceScaleFactorValidator, true, true, WebInspector.UIString("\u2013")));
231 231
232 var mobileCheckbox = this._createSettingCheckbox(WebInspector.UIString(" Emulate mobile"), WebInspector.overridesSupport.settings.emulateMobile); 232 var mobileCheckbox = this._createSettingCheckbox(WebInspector.UIString(" Emulate mobile"), WebInspector.overridesSupport.settings.emulateMobile);
233 WebInspector.Tooltip.install(mobileCheckbox, WebInspector.UIString("Enab le meta viewport, overlay scrollbars, text autosizing and default 980px body wid th")); 233 mobileCheckbox.title = WebInspector.UIString("Enable meta viewport, over lay scrollbars, text autosizing and default 980px body width");
234 fieldsetElement.appendChild(mobileCheckbox); 234 fieldsetElement.appendChild(mobileCheckbox);
235 235
236 fieldsetElement.appendChild(this._createSettingCheckbox(WebInspector.UIS tring("Shrink to fit"), WebInspector.overridesSupport.settings.deviceFitWindow)) ; 236 fieldsetElement.appendChild(this._createSettingCheckbox(WebInspector.UIS tring("Shrink to fit"), WebInspector.overridesSupport.settings.deviceFitWindow)) ;
237 237
238 return fieldsetElement; 238 return fieldsetElement;
239 }, 239 },
240 240
241 __proto__: WebInspector.OverridesView.Tab.prototype 241 __proto__: WebInspector.OverridesView.Tab.prototype
242 } 242 }
243 243
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 * @override 615 * @override
616 * @param {!Object} overridesSupport 616 * @param {!Object} overridesSupport
617 * @return {!Promise} 617 * @return {!Promise}
618 */ 618 */
619 reveal: function(overridesSupport) 619 reveal: function(overridesSupport)
620 { 620 {
621 WebInspector.inspectorView.showViewInDrawer("emulation"); 621 WebInspector.inspectorView.showViewInDrawer("emulation");
622 return Promise.resolve(); 622 return Promise.resolve();
623 } 623 }
624 } 624 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesUI.js ('k') | Source/devtools/front_end/emulation/ResponsiveDesignView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698