Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 1300703004: DevTools: only set title w/ shortcut via Tooltip manager API. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 separatorElement.textContent = ": "; 251 separatorElement.textContent = ": ";
252 252
253 if (this.property.value) { 253 if (this.property.value) {
254 this.valueElement = WebInspector.ObjectPropertiesSection.createValue ElementWithCustomSupport(this.property.value, this.property.wasThrown, this.list ItemElement); 254 this.valueElement = WebInspector.ObjectPropertiesSection.createValue ElementWithCustomSupport(this.property.value, this.property.wasThrown, this.list ItemElement);
255 this.valueElement.addEventListener("contextmenu", this._contextMenuF ired.bind(this, this.property.value), false); 255 this.valueElement.addEventListener("contextmenu", this._contextMenuF ired.bind(this, this.property.value), false);
256 } else if (this.property.getter) { 256 } else if (this.property.getter) {
257 this.valueElement = WebInspector.ObjectPropertyTreeElement.createRem oteObjectAccessorPropertySpan(this.property.parentObject, [this.property.name], this._onInvokeGetterClick.bind(this)); 257 this.valueElement = WebInspector.ObjectPropertyTreeElement.createRem oteObjectAccessorPropertySpan(this.property.parentObject, [this.property.name], this._onInvokeGetterClick.bind(this));
258 } else { 258 } else {
259 this.valueElement = createElementWithClass("span", "object-value-und efined"); 259 this.valueElement = createElementWithClass("span", "object-value-und efined");
260 this.valueElement.textContent = WebInspector.UIString("<unreadable>" ); 260 this.valueElement.textContent = WebInspector.UIString("<unreadable>" );
261 WebInspector.Tooltip.install(this.valueElement, WebInspector.UIStrin g("No property getter")); 261 this.valueElement.title = WebInspector.UIString("No property getter" );
262 } 262 }
263 263
264 this.listItemElement.removeChildren(); 264 this.listItemElement.removeChildren();
265 this.listItemElement.appendChildren(this.nameElement, separatorElement, this.valueElement); 265 this.listItemElement.appendChildren(this.nameElement, separatorElement, this.valueElement);
266 }, 266 },
267 267
268 _contextMenuFired: function(value, event) 268 _contextMenuFired: function(value, event)
269 { 269 {
270 var contextMenu = new WebInspector.ContextMenu(event); 270 var contextMenu = new WebInspector.ContextMenu(event);
271 contextMenu.appendApplicableItems(value); 271 contextMenu.appendApplicableItems(value);
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 return; 1242 return;
1243 if (token === "(") { 1243 if (token === "(") {
1244 params = []; 1244 params = [];
1245 return; 1245 return;
1246 } 1246 }
1247 if (params && tokenType === "js-def") 1247 if (params && tokenType === "js-def")
1248 params.push(token); 1248 params.push(token);
1249 } 1249 }
1250 } 1250 }
1251 } 1251 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698