Issue 13007004: Fix accessible bounding box when page is scrolled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13007004: Fix accessible bounding box when page is scrolled. (Closed)

Created:
7 years, 9 months ago by dmazzoni

Modified:
7 years, 9 months ago

Reviewers:
aboxhall

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix accessible bounding box when page is scrolled. This patch is for merging; will add new test to prevent this from happening again in subsequent changelist. See this diff from the changelist that broke it to see the bug: https://chromiumcodereview.appspot.com/12084028/diff/12004/content/browser/accessibility/browser_accessibility.cc Originally the scrolling logic was applied to the main frame. Change 12084028 intended to have it affect all frames, but instead it affected all frames except the root frame (which has a distinct role in the accessibility tree). BUG=223756 TBR=dtseng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190563

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/browser/accessibility/browser_accessibility.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aboxhall

lgtm Can you update the description to explain why this fixes the problem?

7 years, 9 months ago (2013-03-25 23:57:02 UTC) #2

dmazzoni

On 2013/03/25 23:57:02, aboxhall wrote: > lgtm > > Can you update the description to ...

7 years, 9 months ago (2013-03-26 02:12:06 UTC) #3

dmazzoni

7 years, 9 months ago (2013-03-26 06:14:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r190563 (presubmit successful).

Expand Messages | Collapse Messages