Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 13007003: MIPS: ES6 symbols: turn symbols into a proper primitive type (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: ES6 symbols: turn symbols into a proper primitive type Port r14051 (e9140a92) Original commit message: (qua last week's TC39) Specifically: - Install Symbol constructor function on the global object. - Adjust code generation for typeof. - Remove IsSymbol built-in, IS_SYMBOL macro now defined using typeof. - Remove hack that allowed symbols as constructor results, and some other special cases. - Remove symbol_delegate and GetDelegate function. - Extend ToBoolean stub to handle symbols. - Extend ToNumber to return NaN on symbols. - Poison symbol's toString function, and thereby ToString on symbols. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14058

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +4 lines, -26 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +17 lines, -14 lines 3 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
palfia
7 years, 9 months ago (2013-03-22 21:35:07 UTC) #1
Paul Lind
lgtm. I will land this for you shortly. Please note the nit in the comments, ...
7 years, 9 months ago (2013-03-22 22:14:20 UTC) #2
Paul Lind
Sorry here is the related comment on this code. https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc#newcode5831 src/mips/lithium-codegen-mips.cc:5831: ...
7 years, 9 months ago (2013-03-22 22:15:20 UTC) #3
Paul Lind
Made a small fix, now it really lgtm! https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc#newcode1907 src/mips/lithium-codegen-mips.cc:1907: __ ...
7 years, 9 months ago (2013-03-23 01:23:40 UTC) #4
palfia
https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/13007003/diff/1/src/mips/lithium-codegen-mips.cc#newcode1907 src/mips/lithium-codegen-mips.cc:1907: __ Branch(true_label, eq, at, Operand(SYMBOL_TYPE)); On 2013/03/23 01:23:40, Paul ...
7 years, 9 months ago (2013-03-23 01:49:45 UTC) #5
palfia
7 years, 9 months ago (2013-03-23 02:39:43 UTC) #6
Message was sent while issue was closed.
Committed manually as r14058 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698