Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/isolate.h

Issue 1300663002: Revert "Regularly check hash set addresses to verify memory integrity." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/store-buffer.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index bb1fa417b26244136fd47faf537ef0b5d589c81b..3cc4bacfdec70f14ef337263c38b7df5b6f44bce 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1110,23 +1110,6 @@ class Isolate {
int GetNextUniqueSharedFunctionInfoId() { return next_unique_sfi_id_++; }
#endif
- void set_store_buffer_hash_set_1_address(
- uintptr_t* store_buffer_hash_set_1_address) {
- store_buffer_hash_set_1_address_ = store_buffer_hash_set_1_address;
- }
-
- uintptr_t* store_buffer_hash_set_1_address() {
- return store_buffer_hash_set_1_address_;
- }
-
- void set_store_buffer_hash_set_2_address(
- uintptr_t* store_buffer_hash_set_2_address) {
- store_buffer_hash_set_2_address_ = store_buffer_hash_set_2_address;
- }
-
- uintptr_t* store_buffer_hash_set_2_address() {
- return store_buffer_hash_set_2_address_;
- }
void AddDetachedContext(Handle<Context> context);
void CheckDetachedContextsAfterGC();
@@ -1307,9 +1290,6 @@ class Isolate {
unibrow::Mapping<unibrow::Ecma262Canonicalize> interp_canonicalize_mapping_;
CallInterfaceDescriptorData* call_descriptor_data_;
base::RandomNumberGenerator* random_number_generator_;
- // TODO(hpayer): Remove the following store buffer addresses.
- uintptr_t* store_buffer_hash_set_1_address_;
- uintptr_t* store_buffer_hash_set_2_address_;
// Whether the isolate has been created for snapshotting.
bool serializer_enabled_;
« no previous file with comments | « src/heap/store-buffer.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698