Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1300663002: Revert "Regularly check hash set addresses to verify memory integrity." (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Regularly check hash set addresses to verify memory integrity." This debug check is not needed anymore. This reverts commit ce311ed00123be1ffefdfbee39bd67cec63599ed. BUG= Committed: https://crrev.com/225a2b6f93e9b79f8e4868b52f8878da65a2594a Cr-Commit-Position: refs/heads/master@{#30205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M src/heap/store-buffer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -20 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-17 17:53:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300663002/1
5 years, 4 months ago (2015-08-17 17:53:28 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-17 17:53:29 UTC) #6
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-17 17:54:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300663002/1
5 years, 4 months ago (2015-08-17 17:54:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 18:25:17 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 18:25:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/225a2b6f93e9b79f8e4868b52f8878da65a2594a
Cr-Commit-Position: refs/heads/master@{#30205}

Powered by Google App Engine
This is Rietveld 408576698