Roll src/third_party/android_tools 5722f90:6957ab0

Roll src/third_party/android_tools 5722f90:6957ab0

Summary of changes available at:
https://chromium.googlesource.com/android_tools/+log/5722f90..6957ab0
This also explicitely enables -mstackrealign on x86 Android as it was disabled
by default in NDK r10d.

BUG=521527

[Fabrice (no longer in Chrome), 2015-08-18 11:33:38]

fdegans@chromium.org changed reviewers:
+ thakis@chromium.org

[Fabrice (no longer in Chrome), 2015-08-18 11:35:44]

Nico, PTAL.
This re-enables the latest toolchain for x86 with a fix so it doesn't break
again.

[Nico, 2015-08-18 23:24:52]

lgtm since this rolls the ndk while keeping our current behavior, but I feel we
don't really understand why we need this flag, and we probably shouldn't need it
(and fix the code that requires it), right?

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi#newco...
build/common.gypi:3965: # See crbug.com/521527
https://android-review.googlesource.com/#/c/110770/ sounds like the NDK expects
things to work without this flag. Why do we need this flag?

[Fabrice (no longer in Chrome), 2015-08-18 23:30:59]

Yes, we should probably fix it at some point. But I have no idea where the issue
actually is :/

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi#newco...
build/common.gypi:3965: # See crbug.com/521527
On 2015/08/18 23:24:52, Nico wrote:
> https://android-review.googlesource.com/#/c/110770/ sounds like the NDK
expects
> things to work without this flag. Why do we need this flag?

My best guess is that there is something wrong in one of our x86 assembly files
and the stack gets misaligned at some point. That seems to trigger a crash on
Android x86 Jelly Bean, but not on any other Android x86 versions. Maybe there
is also something wrong with x86 JB system libraries? I honestly am not familiar
enough with the x86 ABI to figure it out and the bug also causes the stack trace
to become garbage, making tracking the underlying issue hard.

[Fabrice (no longer in Chrome), 2015-08-18 23:32:27]

The CQ bit was checked by fdegans@chromium.org

[commit-bot: I haz the power, 2015-08-18 23:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300633002/20001

[Nico, 2015-08-18 23:35:59]

(no need to uncheck cq)

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1300633002/diff/20001/build/common.gypi#newco...
build/common.gypi:3965: # See crbug.com/521527
On 2015/08/18 23:30:59, Fabrice wrote:
> On 2015/08/18 23:24:52, Nico wrote:
> > https://android-review.googlesource.com/#/c/110770/ sounds like the NDK
> expects
> > things to work without this flag. Why do we need this flag?
> 
> My best guess is that there is something wrong in one of our x86 assembly
files
> and the stack gets misaligned at some point. That seems to trigger a crash on
> Android x86 Jelly Bean, but not on any other Android x86 versions. Maybe there
> is also something wrong with x86 JB system libraries? I honestly am not
familiar
> enough with the x86 ABI to figure it out and the bug also causes the stack
trace
> to become garbage, making tracking the underlying issue hard.

Shouldn't the comment be more along the lines of "Figure out why this is needed,
fix, and remove this flag" then?

[commit-bot: I haz the power, 2015-08-18 23:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 23:46:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)