Fix a detection of 64-bit architecture

Fix a detection of 64-bit architecture

This CL fixes a detection of 64-bit architecture when /sbin/init is
symlink. On Ubuntu 15.04, /sbin/init is symlink to /lib/systemd/systemd
and therefore the |file| command doesn't show anything except the path
it refers to.

BUG=
TEST=
R=primiano@chromium.org,sbc@chromium.org,scottmg@chromium.org

Committed: https://crrev.com/0a79d699ff6d87346347aa0f2d91d8e5dddd6924
Cr-Commit-Position: refs/heads/master@{#349373}

[scottmg, 2015-08-17 17:37:54]

scottmg@chromium.org changed reviewers:
+ primiano@chromium.org, sbc@chromium.org
- cjhopman@chromium.org, dpranke@chromium.org, jochen@chromium.org,
thakis@chromium.org

[scottmg, 2015-08-17 17:37:54]

It looks reasonable, but I'm not really familiar with readlink. +primiano +sbc
who will know.

(ki.stfu: On Chrome in general, please only add one reviewer, not everyone in
OWNERS.)

[Primiano Tucci (use gerrit), 2015-08-17 17:45:41]

https://codereview.chromium.org/1300613002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/1300613002/diff/1/build/install-build-deps.sh...
build/install-build-deps.sh:118: if file $(readlink -f /sbin/init) | grep -q
'ELF 64-bit'; then
Can you just do file --dereference  instead?

[Sam Clegg, 2015-08-17 18:05:21]

On 2015/08/17 17:37:54, scottmg wrote:
> It looks reasonable, but I'm not really familiar with readlink. +primiano +sbc
> who will know.
> 
> (ki.stfu: On Chrome in general, please only add one reviewer, not everyone in
> OWNERS.)

lgtm

[ki.stfu, 2015-08-17 18:11:01]

https://codereview.chromium.org/1300613002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/1300613002/diff/1/build/install-build-deps.sh...
build/install-build-deps.sh:118: if file $(readlink -f /sbin/init) | grep -q
'ELF 64-bit'; then
On 2015/08/17 17:45:40, Primiano Tucci wrote:
> Can you just do file --dereference  instead?

Yes, you're right. I haven't seen this option before.

[ki.stfu, 2015-08-17 18:14:18]

On 2015/08/17 17:37:54, scottmg wrote:
> It looks reasonable, but I'm not really familiar with readlink. +primiano +sbc
> who will know.
I'll rework it to use --dereference option.

> (ki.stfu: On Chrome in general, please only add one reviewer, not everyone in
> OWNERS.)
Okay, I got it.

[ki.stfu, 2015-08-17 18:15:38]

Can anyone tell me, why all trybot results are "exception -1"?

[scottmg, 2015-08-17 18:16:33]

Tryjobs are only allowed for a certain list of people (I think to avoid DoS
or something), which I guess you're not on.

On Mon, Aug 17, 2015 at 11:15 AM, ki.stfu@gmail.com via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Can anyone tell me, why all trybot results are "exception -1"?
>
>
> https://codereview.chromium.org/1300613002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sam Clegg, 2015-08-17 22:01:22]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-17 22:03:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300613002/1

[commit-bot: I haz the power, 2015-08-17 22:14:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-17 22:14:19]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Primiano Tucci (use gerrit), 2015-08-18 20:51:42]

LGTM
No need of any trybots. AFAIK no bot is covering this script.

[Primiano Tucci (use gerrit), 2015-08-18 20:51:48]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-08-18 20:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/1300613002/#ps20001
(title: "Use --derenefernce option")

[commit-bot: I haz the power, 2015-08-18 20:52:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300613002/20001

[Nico, 2015-08-18 20:56:03]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-08-18 20:56:04]

rs-lgtm in case that's needed for presubmit

[commit-bot: I haz the power, 2015-08-18 21:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:03:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-08-18 21:04:00]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-08-18 21:04:19]

** Presubmit Warnings **
ki.stfu@gmail.com is not in AUTHORS file. If you are a new contributor, please
visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

[Nico, 2015-08-18 21:04:23]

The CQ bit was unchecked by thakis@chromium.org

[ki.stfu, 2015-09-17 07:18:46]

The CQ bit was checked by ki.stfu@gmail.com

[commit-bot: I haz the power, 2015-09-17 07:18:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300613002/20001

[commit-bot: I haz the power, 2015-09-17 07:27:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-17 07:28:09]

Patchset 2 (id:??) landed as
https://crrev.com/0a79d699ff6d87346347aa0f2d91d8e5dddd6924
Cr-Commit-Position: refs/heads/master@{#349373}