Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 13006019: Revert 190584 "Alternate NTP Mac: Show overlay at fixed position" (Closed)

Created:
7 years, 9 months ago by sail
Modified:
7 years, 9 months ago
Reviewers:
sail
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 190584 "Alternate NTP Mac: Show overlay at fixed position" Speculative revert to see this fixes the Mac startup perf regression. BUG=224002 > Alternate NTP Mac: Show overlay at fixed position > > Previously the overlay was shown at the bottom of the toolbar. The height of > the bookmark bar changes if the bookmark bar is attached. This meant that the > overlay would change positions (relative to the omnibox) depending on the > bookmark bar's attached state. > > With this CL we now show the overlay at the fixed offset from the omnibox. > > One side effect of this is that the bottom of the toolbar can no longer act > as a separator for the overlay. I've changed the overlay to draw its own > separator. > > Screenshot: http://i.imgur.com/ub9gfDo.png > > BUG=173475, 174077 > TBR=sky@chromium.org > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190213 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190519 > > Review URL: https://chromiumcodereview.appspot.com/12674019 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -241 lines) Patch
M trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 4 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 5 chunks +9 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +5 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm View 3 chunks +4 lines, -21 lines 0 comments Download
A + trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_drop_shadow_view_unittest.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_separator_view.h View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_separator_view.mm View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/chrome/browser/ui/cocoa/tab_contents/overlay_separator_view_unittest.mm View 1 chunk +0 lines, -52 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm View 7 chunks +6 lines, -41 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm View 5 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sail
7 years, 9 months ago (2013-03-26 19:33:34 UTC) #1
sail
7 years, 9 months ago (2013-03-26 19:33:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r190732.

Powered by Google App Engine
This is Rietveld 408576698