Add support for taking partial screenshot using touch

ash/wm/partial_screenshot_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/partial_screenshot_view.h"
 
 #include <algorithm>
 
 #include "ash/display/mouse_cursor_event_filter.h"
 #include "ash/screenshot_delegate.h"
@@ skipping 76 matching lines @@
        it != root_windows.end(); ++it) {
     PartialScreenshotView* new_view = new PartialScreenshotView(
         overlay_delegate, screenshot_delegate);
     new_view->Init(*it);
   }
 }
 
 PartialScreenshotView::PartialScreenshotView(
     PartialScreenshotView::OverlayDelegate* overlay_delegate,
     ScreenshotDelegate* screenshot_delegate)
-    : is_dragging_(false),
+    : current_touch_id_(-1),
+      is_dragging_(false),
       overlay_delegate_(overlay_delegate),
       screenshot_delegate_(screenshot_delegate) {
 }
 
 PartialScreenshotView::~PartialScreenshotView() {
   overlay_delegate_ = NULL;
   screenshot_delegate_ = NULL;
 }
 
 void PartialScreenshotView::Init(aura::RootWindow* root_window) {
@@ skipping 83 matching lines @@
   is_dragging_ = false;
   if (screenshot_delegate_) {
     aura::RootWindow *root_window =
         GetWidget()->GetNativeWindow()->GetRootWindow();
     screenshot_delegate_->HandleTakePartialScreenshot(
         root_window,
         gfx::IntersectRects(root_window->bounds(), GetScreenshotRect()));
   }
 }
 
+void PartialScreenshotView::OnTouchEvent(ui::TouchEvent* event) {

[sadrul, 2013/03/25 21:11:04]

You should override OnGestureEvent, and use scroll-gesture events
(ET_GESTURE_SCROLL_BEGIN, SCROLL_UPDATE, and SCROLL_END/ET_SCROLL_FLING_START)
for this.

[Yufeng Shen (Slow to review), 2013/03/25 22:03:34]

Done.

+  gfx::Point position = event->location();
+
+  if (current_touch_id_ != -1 && current_touch_id_ != event->touch_id())

[Jun Mukai, 2013/03/25 21:03:48]

So, this will ignore the second finger touch right?
That would be fine, but not so sure the expected behavior. When the user touch
the screen by two fingers, the user might expect to select the region by those
two fingers?
I'm okay to go ahead with this code, but please discuss about this later in the
crbug.

[Yufeng Shen (Slow to review), 2013/03/25 22:03:34]

I will put a note in the crbug.

+    return;
+
+  if (event->type() == ui::ET_TOUCH_PRESSED) {
+    current_touch_id_ = event->touch_id();
+    ui::MouseEvent mouse_event(ui::ET_MOUSE_PRESSED, position, position, 0);
+    OnMousePressed(mouse_event);
+  } else if (event->type() == ui::ET_TOUCH_MOVED) {
+    ui::MouseEvent mouse_event(ui::ET_MOUSE_DRAGGED, position, position, 0);
+    OnMouseDragged(mouse_event);
+  } else if (event->type() == ui::ET_TOUCH_RELEASED ||
+             event->type() == ui::ET_TOUCH_CANCELLED) {
+    current_touch_id_ = -1;
+    ui::MouseEvent mouse_event(ui::ET_MOUSE_RELEASED, position, position, 0);
+    OnMouseReleased(mouse_event);
+  }

[Jun Mukai, 2013/03/25 21:03:48]

This is okay, but creating dummy mouse event doesn't look excellent. What about:
- extract the logic into other methods, for example
OnSelectionStarted()/OnSelectionChanged()/OnSelectionFinished(), which accepts
location only
- and call them both from Mouse event handlers and here

[sadrul, 2013/03/25 21:11:04]

+1. This is usually how it's done in other parts of the code.

[Yufeng Shen (Slow to review), 2013/03/25 22:03:34]

Done.

+
+  event->SetHandled();
+}
+
 }  // namespace ash