Issue 130053007: [Sheriff] Revert "Check elimination temporarily disabled.", "Fix for buildbot failure after r19102.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130053007: [Sheriff] Revert "Check elimination temporarily disabled.", "Fix for buildbot failure after r19102.… (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

[Sheriff] Revert "Check elimination temporarily disabled.", "Fix for buildbot failure after r19102." and "Check elimination improvement: propagation of state through phis is supported, CheckMap narrowing implemented." This reverts commit r19102, r19105 and r19170 for breaking the Chrome browser_tests. Will reland once fixed. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19179

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -91 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-check-elimination.cc	View	6 chunks	+12 lines, -71 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+2 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 10 months ago (2014-02-07 07:36:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19179 (tree was closed).

Expand Messages | Collapse Messages