Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 130053005: Revert of Enable OrientationEvent only for android. (Closed)

Created:
6 years, 11 months ago by Maria
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Enable OrientationEvent only for android. (https://codereview.chromium.org/131913003/) Reason for revert: Causes crashes on Android on loading a web page, more details in https://code.google.com/p/chromium/issues/detail?id=335258 Original issue's description: > Enable OrientationEvent only for android. > > BUG=181136, 331337 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245210 TBR=darin@chromium.org,mahesh.kk@samsung.com NOTREECHECKS=true NOTRY=true BUG=181136, 331337 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Maria
Created Revert of Enable OrientationEvent only for android.
6 years, 11 months ago (2014-01-16 20:40:24 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-16 20:40:54 UTC) #2
shashi
lgtm
6 years, 11 months ago (2014-01-16 20:44:23 UTC) #3
Nico
lgtm
6 years, 11 months ago (2014-01-16 20:44:32 UTC) #4
Evan Stade
lgtm
6 years, 11 months ago (2014-01-16 20:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/130053005/1
6 years, 11 months ago (2014-01-16 20:45:34 UTC) #6
commit-bot: I haz the power
Change committed as 245310
6 years, 11 months ago (2014-01-16 20:47:29 UTC) #7
maheshkk
6 years, 11 months ago (2014-01-17 17:32:05 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/133173004/ by mahesh.kk@samsung.com.

The reason for reverting is: Fixed the original issue and tested content_shell
to load and pass orientation test case.
https://codereview.chromium.org/141303002/. .

Powered by Google App Engine
This is Rietveld 408576698