Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1300513003: Devtools Color: Sort and expand generated palette (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Color: Sort and expand generated palette This change sorts the generated palette by hue and expands the palette to 24 colors. This change reduces the preview palette size to fix a line wrapping issue on Mac. BUG=521228, 521139, 461320 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M Source/devtools/front_end/elements/Spectrum.js View 2 chunks +18 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/spectrum.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
samli
ptal
5 years, 4 months ago (2015-08-17 02:05:01 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-17 18:49:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300513003/1
5 years, 4 months ago (2015-08-17 23:47:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94365)
5 years, 4 months ago (2015-08-18 01:26:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300513003/1
5 years, 4 months ago (2015-08-18 04:04:33 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:15:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200700

Powered by Google App Engine
This is Rietveld 408576698