Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1300493003: Get rid of a redundant argument DOWNSTREAM from PositionWithAffinity constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T11:03:14 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 7d5811f1f862f720b46893271e349bd63e5512f0..19625fe4e08de91beeb13eff4ec297f6c582840d 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -94,7 +94,7 @@ VisiblePosition VisiblePosition::previous(EditingBoundaryCrossingRule rule) cons
// we should always be able to make the affinity DOWNSTREAM, because going previous from an
// UPSTREAM position can never yield another UPSTREAM position (unless line wrap length is 0!).
if (prev.isNotNull() && m_affinity == UPSTREAM) {
- ASSERT(inSameLine(PositionWithAffinity(prev.deepEquivalent(), DOWNSTREAM), PositionWithAffinity(prev.deepEquivalent(), UPSTREAM)));
+ ASSERT(inSameLine(PositionWithAffinity(prev.deepEquivalent()), PositionWithAffinity(prev.deepEquivalent(), UPSTREAM)));
}
#endif
@@ -652,7 +652,7 @@ void VisiblePosition::init(const PositionAlgorithm<Strategy>& position, EAffinit
}
// When not at a line wrap, make sure to end up with DOWNSTREAM affinity.
- if (!inSameLine(PositionWithAffinityTemplate<Strategy>(deepPosition, DOWNSTREAM), PositionWithAffinityTemplate<Strategy>(deepPosition, UPSTREAM)))
+ if (!inSameLine(PositionWithAffinityTemplate<Strategy>(deepPosition), PositionWithAffinityTemplate<Strategy>(deepPosition, UPSTREAM)))
return;
m_affinity = DOWNSTREAM;
}
« no previous file with comments | « no previous file | Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698