Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300493003: Get rid of a redundant argument DOWNSTREAM from PositionWithAffinity constructor call sites (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of a redundant argument DOWNSTREAM from PositionWithAffinity constructor call sites This patch gets rid of a redundant argument DOWNSTREAM from |PositionWithAffinity| constructor call sites to simplify source code for improving code health, since default value of affinity is |DOWNSTREAM| in a constructor declarations. This patch is a preparation of introducing |TextAffinity| enum class as replacement of |EAffinity|, http://crbug.com/522038. BUG=522038 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200808

Patch Set 1 : 2015-08-19T11:03:14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/editing/VisiblePosition.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 02:27:26 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-19 02:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300493003/1
5 years, 4 months ago (2015-08-19 02:30:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/108741)
5 years, 4 months ago (2015-08-19 03:08:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300493003/1
5 years, 4 months ago (2015-08-19 03:18:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95096)
5 years, 4 months ago (2015-08-19 06:25:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300493003/1
5 years, 4 months ago (2015-08-19 07:22:46 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 08:35:40 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200808

Powered by Google App Engine
This is Rietveld 408576698