Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1300483002: [DevTools] Add maximum limit to throttling values. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
paulirish, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add maximum limit to throttling values. TBR=pfeldman BUG=520483 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/components/NetworkConditionsSelector.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300483002/1
5 years, 4 months ago (2015-08-15 00:42:37 UTC) #2
paulirish
On 2015/08/15 at 00:42:53, paulirish wrote: > The CQ bit was unchecked by paulirish@chromium.org accidental ...
5 years, 4 months ago (2015-08-15 00:43:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300483002/1
5 years, 4 months ago (2015-08-15 00:43:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/121673)
5 years, 4 months ago (2015-08-15 01:33:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300483002/1
5 years, 4 months ago (2015-08-15 02:03:23 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 02:25:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200591

Powered by Google App Engine
This is Rietveld 408576698