Upload/Download dart_snapshotter

mojo/public/tools/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/module_args/mojo.gni")
 import("../mojo.gni")
 
 if (mojo_use_prebuilt_mojo_shell) {
   copy("copy_mojo_shell") {
     filename = "mojo_shell"
@@ skipping 10 matching lines @@
       sources = [
         "prebuilt/shell/linux-x64/$filename",
       ]
       outputs = [
         "$root_out_dir/$filename",
       ]
     }
   }
 }
 
+if (mojo_use_prebuilt_dart_snapshotter) {
+  copy("copy_dart_snapshotter") {
+    sources = [
+      "prebuilt/dart_snapshotter/linux-x64/dart_snapshotter",

[jamesr, 2015/08/14 22:55:02]

this doesn't look like the right binary to use when developing on a mac host

[zra, 2015/08/17 15:06:16]

I didn't see a Mac builder for Mojo. Is there one?

[jamesr, 2015/08/17 17:29:39]

There is not, but developing from a Mac host is supported (on a best-effort
basis).  We provide linux and mac host binaries for other blobs.

[zra, 2015/08/17 21:59:18]

I've modified here and the upload_binaries.py script to do what I think might be
the right thing, but I think I don't understand how the mac host binaries are
provided if they aren't uploaded by a mac builder somewhere.

+    ]
+    if (is_android) {

[jamesr, 2015/08/14 22:55:01]

do you want to test for "is_android" here or "am i cross compiling"? do you need
the snapshotter for the host or target build?

[zra, 2015/08/17 15:06:16]

Right now in this CL, the snapshotter is invoked during the target build. Since
the Dart .mojo apps are platform agnostic, it could just as well be invoked for
the host build. I'm going to give that a try and see if it will help clean this
up.

[jamesr, 2015/08/17 17:29:39]

I think at a minimum you shouldn't need to invoke the copy step for both the
host and target toolchain.

You could have the copy step declare a data dependency on a copy that runs in
the host toolchain, depending on if that makes more sense (imo it would since in
the non-prebuilt state the snapshotter has to be built in the host toolchain)

[zra, 2015/08/17 21:59:18]

Done.

+      toolchain_name = get_label_info(host_toolchain, "name")
+      outputs = [
+        "$root_out_dir/$toolchain_name/dart_snapshotter",

[jamesr, 2015/08/14 22:55:01]

hm, doesn't root_out_dir already contain the current toolchain?

[zra, 2015/08/17 15:06:16]

If the current toolchain is the target toolchain, root_out_dir is e.g.
//out/android_Debug/. If the current toolchain is something else then
root_out_dir is //out/android_debug/$toolchain_name/

+      ]
+    } else {
+      assert(is_linux)
+      outputs = [
+        "$root_out_dir/dart_snapshotter",
+      ]
+    }
+  }
+}
+
 if (mojo_use_prebuilt_network_service) {
   copy("copy_network_service") {
     filename = "network_service.mojo"
     if (defined(mojo_prebuilt_network_service_location) &&
         mojo_prebuilt_network_service_location != "") {
       sources = [
         "$mojo_prebuilt_network_service_location",
       ]
     } else {
       if (is_android) {
@@ skipping 50 matching lines @@
 if (mojo_use_dart_apptest_framework) {
   copy("dart_apptest_framework") {
     sources = [
       "prebuilt/frameworks/apptest.dartzip",
     ]
     outputs = [
       "$target_out_dir/dart_apptest_framework.dartzip",
     ]
   }
 }