Upload/Download dart_snapshotter

mojo/public/dart/rules.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file has rules for making Dart packages and Dart-based Mojo applications.
 #
 # Entrypoint rules are:
 # - dart_pkg
 # - dartzip_package
 # - dartzip_packaged_application
 
+import("../mojo.gni")
 import("//build/module_args/mojo.gni")
 import("//build/module_args/dart.gni")
 
 template("dartx") {
   bundle_prefix = target_name
   bundle = "$target_gen_dir/${bundle_prefix}.dartx"
   snapshot = "$target_gen_dir/${bundle_prefix}_snapshot.bin"
-  dart_snapshotter = "$root_out_dir/dart_snapshotter"
-  if (current_toolchain != host_toolchain) {
-    toolchain_name = get_label_info(host_toolchain, "name")
-    dart_snapshotter = "$root_out_dir/$toolchain_name/dart_snapshotter"
+
+  if (mojo_use_prebuilt_dart_snapshotter) {
+    dart_snapshotter_rule =
+        rebase_path("mojo/public/tools:copy_dart_snapshotter", ".", mojo_root)
+  } else {
+    dart_snapshotter_rule =
+        rebase_path("mojo/dart/dart_snapshotter", ".", mojo_root)

[jamesr, 2015/08/17 20:59:51]

the sdk should not depend on paths outside the sdk. if you want to allow
specifying a label in the host environment (i.e. the mojo checkout) make that an
optional parameter in //build/module_args/

[zra, 2015/08/17 21:59:18]

Used the variable you added.

   }
+  data_deps = [ "$dart_snapshotter_rule($host_toolchain)" ]

[jamesr, 2015/08/17 20:59:51]

data_deps is wrong since you need this to exist before you can start running the
action. use deps

[zra, 2015/08/17 21:59:18]

Fixed after your change.

+  dart_snapshotter_dir =
+      get_label_info("$dart_snapshotter_rule($host_toolchain)", "root_out_dir")
+  dart_snapshotter = "$dart_snapshotter_dir/dart_snapshotter"
 
   action("gen_${bundle_prefix}_snapshot") {
     main_dart = invoker.main_dart
 
     inputs = [
       dart_snapshotter,
       main_dart,
     ]
     outputs = [
       snapshot,
@@ skipping 562 matching lines @@
 
     rebase_input = rebase_path(input, root_build_dir)
     rebase_output = rebase_path(output, root_build_dir)
     args = [
       "--input=$rebase_input",
       "--output=$rebase_output",
       "--line=$line",
     ]
   }
 }