Issue 1300433003: Add range toJSON and fromDict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1300433003: Add range toJSON and fromDict (Closed)

Created:
5 years, 4 months ago by nduca

Modified:
5 years, 4 months ago

Reviewers:
beaudoin

CC:
catapult-reviews_chromium.org, tracing-review_chromium.org

Base URL:
https://github.com/catapult-project/catapult.git@master

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

More Reviews

Description

Add range toJSON and fromDict Right now it serializes as "{isEmpty_: false}". R=beaudoin Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8a21664993b6beaf3080c81d4a5924131e600767

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	tracing/tracing/base/range.html	View		1 chunk	+23 lines, -0 lines	0 comments	Download
	M	tracing/tracing/base/range_test.html	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300433003/1

5 years, 4 months ago (2015-08-14 22:47:00 UTC) #3

commit-bot: I haz the power

5 years, 4 months ago (2015-08-14 22:58:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages