Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1300403003: Revert of Implement canComputeFastBounds() for image filters. (Closed)

Created:
5 years, 4 months ago by herb_g
Modified:
5 years, 4 months ago
Reviewers:
Stephen White, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Implement canComputeFastBounds() for image filters. (patchset #8 id:130001 of https://codereview.chromium.org/1296943002/ ) Reason for revert: This causes a syntax error. http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/87819/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Implement canComputeFastBounds() for image filters. > > Image filters have never implemented this check, which means that > filters which affect transparent black falsely claim they can compute > their bounds. > > Implemented an affectsTransparentBlack() virtual for image > filters, and a similar helper function for color filters. > > This will affect the following GMs: imagefiltersscaled > (lighting, perlin noise now filter to clip), > colorfilterimagefilter (new test case), imagefiltersclipped > (perlin noise now filters to clip). > > Note: I de-inlined SkPaint::canComputeFastBounds() to avoid adding > a dependency from SkPaint.h to SkImageFilter.h.h. Skia benches show > no impact from this change, but will watch the perf bots carefully. > > BUG=4212 > > Committed: https://skia.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb TBR=reed@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=4212 Committed: https://skia.googlesource.com/skia/+/12d8472d31ea5edb636d7d5214db253570115c40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -117 lines) Patch
M gm/colorfilterimagefilter.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkImageFilter.h View 3 chunks +0 lines, -12 lines 0 comments Download
M include/core/SkPaint.h View 3 chunks +7 lines, -2 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkLightingImageFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +0 lines, -53 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herb_g
Created Revert of Implement canComputeFastBounds() for image filters.
5 years, 4 months ago (2015-08-20 16:28:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300403003/1
5 years, 4 months ago (2015-08-20 16:28:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/12d8472d31ea5edb636d7d5214db253570115c40
5 years, 4 months ago (2015-08-20 16:28:49 UTC) #3
Stephen White
5 years, 4 months ago (2015-08-20 18:10:21 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1301823005/ by senorblanco@chromium.org.

The reason for reverting is: The Mac compile issue was fixed here:
https://chromium.googlesource.com/chromium/src/+/fdd331a42ae0b9a6909a12102073....

Powered by Google App Engine
This is Rietveld 408576698