Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: ppapi/proxy/ppb_image_data_proxy.cc

Issue 13004012: Implement the host side of the PPB_PDF proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_image_data_proxy.cc
diff --git a/ppapi/proxy/ppb_image_data_proxy.cc b/ppapi/proxy/ppb_image_data_proxy.cc
index b2ede29954ed210fece2131bc1fbd00abca54590..a5647a3e73d4b901b442ba7f822a72025a9e8977 100644
--- a/ppapi/proxy/ppb_image_data_proxy.cc
+++ b/ppapi/proxy/ppb_image_data_proxy.cc
@@ -521,6 +521,8 @@ bool PPB_ImageData_Proxy::OnMessageReceived(const IPC::Message& msg) {
}
#if !defined(OS_NACL)
+// TODO(raymes): Do we leak resources in these Create functions if the code
+// fails to return a handle to the plugin?
yzshen1 2013/04/03 18:32:39 The resource is passed to the plugin side as HostR
raymes 2013/04/03 23:18:21 ok I removed the todo
void PPB_ImageData_Proxy::OnHostMsgCreate(PP_Instance instance,
int32_t format,
const PP_Size& size,

Powered by Google App Engine
This is Rietveld 408576698