Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 13004003: gpu: Cache results of GetShaderPrecisionFormat client-side (Closed)

Created:
7 years, 9 months ago by brianderson
Modified:
7 years, 9 months ago
CC:
chromium-reviews, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@shp3
Visibility:
Public.

Description

gpu: Cache results of GetShaderPrecisionFormat client-side This will allow us to avoid making the round-trip call to the server every time this function is called. BUG=222894 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190205

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : re-upload #

Total comments: 6

Patch Set 4 : Use SetMemory and GetPut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -5 lines) Patch
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
brianderson
This method is pretty straightforward - it caches values lazily. Would it also be worth ...
7 years, 9 months ago (2013-03-21 22:02:22 UTC) #1
Ken Russell (switch to Gerrit)
Gregg should review this. Where are the try jobs? Does this change pass the gpu ...
7 years, 9 months ago (2013-03-21 22:22:41 UTC) #2
brianderson
On 2013/03/21 22:22:41, kbr wrote: > Gregg should review this. > > Where are the ...
7 years, 9 months ago (2013-03-21 22:31:05 UTC) #3
greggman
Please add or update the unit test so that it calls GLES2Implementation::GetShaderPrecisionFormat 3 times. Once ...
7 years, 9 months ago (2013-03-21 22:52:19 UTC) #4
brianderson
Added the test.
7 years, 9 months ago (2013-03-22 02:54:34 UTC) #5
brianderson
https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc File gpu/command_buffer/client/gles2_implementation_unittest.cc (right): https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc#newcode659 gpu/command_buffer/client/gles2_implementation_unittest.cc:659: ((char*)commands_) + sizeof(expected1), Is there a better way of ...
7 years, 9 months ago (2013-03-22 18:18:17 UTC) #6
greggman
lgtm https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc File gpu/command_buffer/client/gles2_implementation_unittest.cc (right): https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc#newcode622 gpu/command_buffer/client/gles2_implementation_unittest.cc:622: .WillOnce(Invoke(run_server1)) Could you have just used SetMemory? https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc#newcode659 ...
7 years, 9 months ago (2013-03-22 22:06:14 UTC) #7
brianderson
https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc File gpu/command_buffer/client/gles2_implementation_unittest.cc (right): https://codereview.chromium.org/13004003/diff/10001/gpu/command_buffer/client/gles2_implementation_unittest.cc#newcode622 gpu/command_buffer/client/gles2_implementation_unittest.cc:622: .WillOnce(Invoke(run_server1)) On 2013/03/22 22:06:14, greggman wrote: > Could you ...
7 years, 9 months ago (2013-03-22 23:11:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/13004003/16001
7 years, 9 months ago (2013-03-22 23:26:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/13004003/16001
7 years, 9 months ago (2013-03-23 16:06:31 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 05:08:35 UTC) #11
Message was sent while issue was closed.
Change committed as 190205

Powered by Google App Engine
This is Rietveld 408576698