Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300323003: Make flex-grow and flex-shrink interpolation continuous with 0 (Closed)

Created:
5 years, 4 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make flex-grow and flex-shrink interpolation continuous with 0 The current flex-grow and flex-shrink interpolation code will not smoothly interpolate values with 0. This patch removes this special behaviour as there is no specification text justifying this behaviour. Without this behaviour we can simplify the Constraint enum out of AnimatableDouble. BUG=522817 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201097

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -44 lines) Patch
M LayoutTests/animations/interpolation/flex-grow-interpolation.html View 3 chunks +29 lines, -7 lines 0 comments Download
M LayoutTests/animations/interpolation/flex-shrink-interpolation.html View 1 chunk +11 lines, -3 lines 0 comments Download
M LayoutTests/transitions/flex-transitions.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/transitions/flex-transitions-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.h View 2 chunks +3 lines, -11 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (13 generated)
alancutter (OOO until 2018)
5 years, 4 months ago (2015-08-20 06:54:13 UTC) #2
dstockwell
lgtm
5 years, 4 months ago (2015-08-20 14:49:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/1
5 years, 4 months ago (2015-08-20 23:20:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101557)
5 years, 4 months ago (2015-08-21 00:28:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/20001
5 years, 4 months ago (2015-08-21 01:07:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58737)
5 years, 4 months ago (2015-08-21 07:53:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/20001
5 years, 4 months ago (2015-08-24 00:14:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102882)
5 years, 4 months ago (2015-08-24 01:52:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/20001
5 years, 4 months ago (2015-08-24 06:14:25 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102945)
5 years, 4 months ago (2015-08-24 07:49:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/20001
5 years, 4 months ago (2015-08-25 00:05:22 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103462)
5 years, 4 months ago (2015-08-25 01:14:00 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300323003/20001
5 years, 4 months ago (2015-08-25 02:33:49 UTC) #26
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 03:41:46 UTC) #27
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201097

Powered by Google App Engine
This is Rietveld 408576698