Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 1300303002: Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 1300303002: Introduce isVisuallyEquivalentCandidate() as replacement of PositionAlgorithm::isCandidate() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-21T01:27:16 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index 259290de4dbca0f1d09f0a9a86fb5f75ef2a93a2..b6699d7c2b89ffc9ab58f8b3687a1a090845ebdf 100644

--- a/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -184,7 +184,7 @@ void InsertParagraphSeparatorCommand::doApply()

// Use the leftmost candidate.

insertionPosition = insertionPosition.upstream();

- if (!insertionPosition.isCandidate())

+ if (!isVisuallyEquivalentCandidate(insertionPosition))

insertionPosition = insertionPosition.downstream();

// Adjust the insertion position after the delete

« no previous file with comments | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/editing/commands/InsertTextCommand.cpp » ('j') | no next file with comments »