Issue 13003004: Support multi touch on Windows 8 AURA and ASH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13003004: Support multi touch on Windows 8 AURA and ASH. (Closed)

Created:
7 years, 9 months ago by ananta

Modified:
7 years, 9 months ago

Reviewers:
palmer, cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Support multi touch on Windows 8 AURA and ASH. The touch events coming in from desktop chrome AURA and ASH have hardcoded touch ids which breaks the gesture recognizer as it is unable to figure out that multiple touch points are involved. Fix on desktop Chrome AURA is to use the OS generated touch id mapped to the gesture recognizer range. For ASH Windows 8 we pass in the mapped touch ids from the metro driver in the touch IPC messages. Fixes bug https://code.google.com/p/chromium/issues/detail?id=179977 BUG=179977 R=cpu,sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191015

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -28 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura/remote_root_window_host_win.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/aura/remote_root_window_host_win.cc	View		2 chunks	+13 lines, -9 lines	0 comments	Download
M	ui/metro_viewer/metro_viewer_messages.h	View		1 chunk	+9 lines, -6 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	win8/metro_driver/chrome_app_view_ash.cc	View		7 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ananta

7 years, 9 months ago (2013-03-27 20:49:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r191015 (presubmit successful).

Expand Messages | Collapse Messages