webtry/go/webtry/main.go - Issue 1300273002: Reland of Add a library for running external commands, providing timeouts and test injection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webtry/go/webtry/main.go

Issue 1300273002: Reland of Add a library for running external commands, providing timeouts and test injection. (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Fix squashWriters for struct arguments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webtry/go/webtry/main.go

diff --git a/webtry/go/webtry/main.go b/webtry/go/webtry/main.go

index 84c1451ce36ac0a879e660afe6d7b5602118a921..547900ddfccf89fe0a22207adbb6f1f5f052359d 100644

--- a/webtry/go/webtry/main.go

+++ b/webtry/go/webtry/main.go

@@ -34,6 +34,7 @@ import (

metrics "github.com/rcrowley/go-metrics"

"github.com/skia-dev/glog"

"go.skia.org/infra/go/common"

+ "go.skia.org/infra/go/exec"

"go.skia.org/infra/go/metadata"

"go.skia.org/infra/go/util"

"go.skia.org/infra/webtry/go/config"

@@ -179,7 +180,7 @@ func Init() {

// f672cead70404080a991ebfb86c38316a4589b23 2014-04-27 19:21:51 +0000

- logOutput, err := util.DoCmd(`git log --format=%H%x20%ai HEAD^..HEAD`)

+ logOutput, err := exec.RunSimple(`git log --format=%H%x20%ai HEAD^..HEAD`)

if err != nil {

panic(err)

}

@@ -1052,7 +1053,7 @@ func mainHandler(w http.ResponseWriter, r *http.Request) {

cmd += fmt.Sprintf(" --source image-%d.png", request.Source)

}

- message, err := util.DoCmd(cmd)

+ message, err := exec.RunSimple(cmd)

buildAndRunOutput := strings.SplitN(message, "-=-=-=-=-=-=-", 2)

« no previous file with comments | « go/util/util_test.go ('k') | no next file » | no next file with comments »