Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: Source/platform/heap/GCInfo.h

Issue 1300263003: Fix perf regression in blink_perf.shadow_dom. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/platform/heap/Visitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GCInfo_h 5 #ifndef GCInfo_h
6 #define GCInfo_h 6 #define GCInfo_h
7 7
8 #include "platform/heap/Visitor.h" 8 #include "platform/heap/Visitor.h"
9 #include "wtf/Assertions.h" 9 #include "wtf/Assertions.h"
10 #include "wtf/Atomics.h" 10 #include "wtf/Atomics.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 104
105 // GCInfo contains meta-data associated with objects allocated in the 105 // GCInfo contains meta-data associated with objects allocated in the
106 // Blink heap. This meta-data consists of a function pointer used to 106 // Blink heap. This meta-data consists of a function pointer used to
107 // trace the pointers in the object during garbage collection, an 107 // trace the pointers in the object during garbage collection, an
108 // indication of whether or not the object needs a finalization 108 // indication of whether or not the object needs a finalization
109 // callback, and a function pointer used to finalize the object when 109 // callback, and a function pointer used to finalize the object when
110 // the garbage collector determines that the object is no longer 110 // the garbage collector determines that the object is no longer
111 // reachable. There is a GCInfo struct for each class that directly 111 // reachable. There is a GCInfo struct for each class that directly
112 // inherits from GarbageCollected or GarbageCollectedFinalized. 112 // inherits from GarbageCollected or GarbageCollectedFinalized.
113 struct GCInfo { 113 struct GCInfo {
114 using GetClassNameCallback = const String& (*)();
115
116 bool hasFinalizer() const { return m_nonTrivialFinalizer; } 114 bool hasFinalizer() const { return m_nonTrivialFinalizer; }
117 bool hasVTable() const { return m_hasVTable; } 115 bool hasVTable() const { return m_hasVTable; }
118 const String& className() const { return m_classNameGetter(); } 116 const String& className() const { return m_className; }
119 TraceCallback m_trace; 117 TraceCallback m_trace;
120 FinalizationCallback m_finalize; 118 FinalizationCallback m_finalize;
121 bool m_nonTrivialFinalizer; 119 bool m_nonTrivialFinalizer;
122 bool m_hasVTable; 120 bool m_hasVTable;
123 GetClassNameCallback m_classNameGetter; 121 // |m_className| is held as a reference to prevent dtor being called at exit .
122 const String& m_className;
124 }; 123 };
125 124
126 #if ENABLE(ASSERT) 125 #if ENABLE(ASSERT)
127 PLATFORM_EXPORT void assertObjectHasGCInfo(const void*, size_t gcInfoIndex); 126 PLATFORM_EXPORT void assertObjectHasGCInfo(const void*, size_t gcInfoIndex);
128 #endif 127 #endif
129 128
130 class GCInfoTable { 129 class GCInfoTable {
131 public: 130 public:
132 PLATFORM_EXPORT static void ensureGCInfoIndex(const GCInfo*, size_t*); 131 PLATFORM_EXPORT static void ensureGCInfoIndex(const GCInfo*, size_t*);
133 132
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 template<typename T> 164 template<typename T>
166 struct GCInfoAtBase { 165 struct GCInfoAtBase {
167 static size_t index() 166 static size_t index()
168 { 167 {
169 static_assert(sizeof(T), "T must be fully defined"); 168 static_assert(sizeof(T), "T must be fully defined");
170 static const GCInfo gcInfo = { 169 static const GCInfo gcInfo = {
171 TraceTrait<T>::trace, 170 TraceTrait<T>::trace,
172 FinalizerTrait<T>::finalize, 171 FinalizerTrait<T>::finalize,
173 FinalizerTrait<T>::nonTrivialFinalizer, 172 FinalizerTrait<T>::nonTrivialFinalizer,
174 WTF::IsPolymorphic<T>::value, 173 WTF::IsPolymorphic<T>::value,
175 TypenameStringTrait<T>::get 174 TypenameStringTrait<T>::get()
176 }; 175 };
177 RETURN_GCINFO_INDEX(); 176 RETURN_GCINFO_INDEX();
178 } 177 }
179 }; 178 };
180 179
181 template<typename T, bool = WTF::IsSubclassOfTemplate<typename WTF::RemoveConst< T>::Type, GarbageCollected>::value> struct GetGarbageCollectedBase; 180 template<typename T, bool = WTF::IsSubclassOfTemplate<typename WTF::RemoveConst< T>::Type, GarbageCollected>::value> struct GetGarbageCollectedBase;
182 181
183 template<typename T> 182 template<typename T>
184 struct GetGarbageCollectedBase<T, true> { 183 struct GetGarbageCollectedBase<T, true> {
185 typedef typename T::GarbageCollectedBase type; 184 typedef typename T::GarbageCollectedBase type;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 template<typename T, size_t inlineCapacity> 218 template<typename T, size_t inlineCapacity>
220 struct GCInfoTrait<HeapVector<T, inlineCapacity>> : public GCInfoTrait<Vector<T, inlineCapacity, HeapAllocator>> { }; 219 struct GCInfoTrait<HeapVector<T, inlineCapacity>> : public GCInfoTrait<Vector<T, inlineCapacity, HeapAllocator>> { };
221 template<typename T, size_t inlineCapacity> 220 template<typename T, size_t inlineCapacity>
222 struct GCInfoTrait<HeapDeque<T, inlineCapacity>> : public GCInfoTrait<Deque<T, i nlineCapacity, HeapAllocator>> { }; 221 struct GCInfoTrait<HeapDeque<T, inlineCapacity>> : public GCInfoTrait<Deque<T, i nlineCapacity, HeapAllocator>> { };
223 template<typename T, typename U, typename V> 222 template<typename T, typename U, typename V>
224 struct GCInfoTrait<HeapHashCountedSet<T, U, V>> : public GCInfoTrait<HashCounted Set<T, U, V, HeapAllocator>> { }; 223 struct GCInfoTrait<HeapHashCountedSet<T, U, V>> : public GCInfoTrait<HashCounted Set<T, U, V, HeapAllocator>> { };
225 224
226 } // namespace blink 225 } // namespace blink
227 226
228 #endif 227 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/platform/heap/Visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698