Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1300263003: Fix perf regression in blink_perf.shadow_dom. (Closed)

Created:
5 years, 4 months ago by ssid
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix perf regression in blink_perf.shadow_dom. The static strings were destructed at the exit instead of leaked, causing performance regression. Since the GCInfo objects are leaked, holding a reference in the struct will leak the strings. BUG=520948 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M Source/platform/heap/GCInfo.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/platform/heap/Visitor.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ssid
PTAL. Sorry for the roundtrips, I think this will fix all the issues. Please tell ...
5 years, 4 months ago (2015-08-20 10:07:31 UTC) #2
haraken
LGTM, thanks for working on this!
5 years, 4 months ago (2015-08-20 11:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300263003/1
5 years, 4 months ago (2015-08-20 11:22:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95967)
5 years, 4 months ago (2015-08-20 12:46:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300263003/1
5 years, 4 months ago (2015-08-21 00:23:29 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 00:31:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200944

Powered by Google App Engine
This is Rietveld 408576698