Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp

Issue 1300213004: Restore the "don't flatten scrolling content layer" logic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: merge conflict Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
diff --git a/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp b/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
index ff9151aac9a36797b0029dedc8093deb200bf711..3a2c3683122e2867aee88aab8fefe3fec6ada5e3 100644
--- a/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
+++ b/Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
@@ -1471,6 +1471,16 @@ void CompositedDeprecatedPaintLayerMapping::updateShouldFlattenTransform()
layer->setShouldFlattenTransform(false);
}, ApplyToChildContainingLayers);
}
+
+ // Regardless, mark the scrolling contents layer and scrolling block
+ // selection layer (if they exist) as not flattening. Having them flatten
+ // causes unclipped render surfaces which cause bugs.
+ // http://crbug.com/521768
+ if (hasScrollingLayer()) {
+ m_scrollingContentsLayer->setShouldFlattenTransform(false);
+ if (m_scrollingBlockSelectionLayer)
+ m_scrollingBlockSelectionLayer->setShouldFlattenTransform(false);
+ }
}
bool CompositedDeprecatedPaintLayerMapping::updateForegroundLayer(bool needsForegroundLayer)
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698