Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300213004: Restore the "don't flatten scrolling content layer" logic. (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
Ian Vollick, ajuma
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Restore the "don't flatten scrolling content layer" logic. This restores some logic removed in https://codereview.chromium.org/1030323005/. This seems to change some of Blink's behaviour back, and will hopefully resolve issues with unclipped render surfaces. BUG=521768 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201138

Patch Set 1 #

Patch Set 2 : add comment, remove !hasClippingLayer condition #

Patch Set 3 : TestExpectations #

Patch Set 4 : merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 3 chunks +47 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
jbroman
5 years, 4 months ago (2015-08-24 17:44:06 UTC) #2
ajuma
lgtm, hopefully all this logic will become saner with SP v2.
5 years, 4 months ago (2015-08-24 17:48:54 UTC) #3
Ian Vollick
On 2015/08/24 17:48:54, ajuma wrote: > lgtm, hopefully all this logic will become saner with ...
5 years, 4 months ago (2015-08-24 18:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300213004/60001
5 years, 4 months ago (2015-08-24 18:20:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59907)
5 years, 4 months ago (2015-08-24 18:33:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300213004/60001
5 years, 4 months ago (2015-08-24 19:38:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59964)
5 years, 4 months ago (2015-08-24 20:30:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300213004/60001
5 years, 4 months ago (2015-08-25 14:31:04 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-25 15:30:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300213004/60001
5 years, 4 months ago (2015-08-25 16:02:25 UTC) #18
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-25 16:02:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300213004/60001
5 years, 3 months ago (2015-08-25 17:02:02 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 17:07:04 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201138

Powered by Google App Engine
This is Rietveld 408576698