Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: tests/BitmapFactoryTest.cpp

Issue 13002002: "Fix" persistent failure of BitmapFactoryTest on debug RazrI (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/BitmapFactoryTest.cpp
===================================================================
--- tests/BitmapFactoryTest.cpp (revision 8301)
+++ tests/BitmapFactoryTest.cpp (working copy)
@@ -79,9 +79,8 @@
!= SkImageCache::kPinned_MemoryStatus);
memory = cache->pinCache(ID, &dataStatus);
if (memory != NULL) {
- // Since the cache was thrown away, and ID was not pinned, it should have
- // been purged.
- REPORTER_ASSERT(reporter, SkImageCache::kUninitialized_DataStatus == dataStatus);
+ // The memory block may or may not have survived the purging (at the
+ // memory manager's whim) so we cannot check dataStatus here.
cache->releaseCache(ID);
REPORTER_ASSERT(reporter, cache->getMemoryStatus(ID)
!= SkImageCache::kPinned_MemoryStatus);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698