Issue 13002002: "Fix" persistent failure of BitmapFactoryTest on debug RazrI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13002002: "Fix" persistent failure of BitmapFactoryTest on debug RazrI (Closed)

Created:
7 years, 9 months ago by robertphillips

Modified:
7 years, 9 months ago

Reviewers:
scroggo, djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The RazrI has been failing in Debug on the BitmapFactoryTest. This is because ashmem is retaining a memory block the test expects to be freed. Since this is perfectly reasonable behavior on the memory manager's part I have altered the test to not expect the memory block to be freed.

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/BitmapFactoryTest.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

committed as r8311

Expand Messages | Collapse Messages