Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300163002: unsigned -> int for counts and indices in picture-related code (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

unsigned -> int for counts and indices in picture-related code also, (C) BUG=skia: Committed: https://skia.googlesource.com/skia/+/c6ad06acefa096716f8dabed5342f9b89dc43dfe

Patch Set 1 #

Patch Set 2 : (C) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -138 lines) Patch
M bench/RTreeBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBBoxHierarchy.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBigPicture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBigPicture.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkLayerInfo.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRTree.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkRTree.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRecord.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordDraw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecordDraw.cpp View 13 chunks +19 lines, -19 lines 0 comments Download
M src/core/SkRecordOpts.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkRecordPattern.h View 5 chunks +12 lines, -5 lines 0 comments Download
M src/core/SkRecorder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 11 chunks +26 lines, -26 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 9 chunks +21 lines, -21 lines 0 comments Download
M tests/PictureTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/RTreeTest.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/RecordOptsTest.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/RecordPatternTest.cpp View 1 3 chunks +9 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/RecordTestUtils.h View 1 4 chunks +10 lines, -3 lines 0 comments Download
M tests/RecorderTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/DumpRecord.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300163002/20001
5 years, 4 months ago (2015-08-19 15:37:14 UTC) #2
mtklein_C
First lgtm wins.
5 years, 4 months ago (2015-08-19 15:42:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 15:43:42 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-08-19 16:41:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300163002/20001
5 years, 4 months ago (2015-08-19 16:50:18 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:51:05 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c6ad06acefa096716f8dabed5342f9b89dc43dfe

Powered by Google App Engine
This is Rietveld 408576698