Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 1300143002: permissions: fix small mistakes in error messages (Closed)

Created:
5 years, 4 months ago by Lalit Maganti
Modified:
5 years, 4 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

permissions: fix small mistakes in error messages BUG=(none) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/modules/permissions/Permissions.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lalit Maganti
Mounir: Just a quick rubberstamp required.
5 years, 4 months ago (2015-08-19 14:28:10 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 4 months ago (2015-08-19 14:43:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300143002/1
5 years, 4 months ago (2015-08-19 14:44:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/41626)
5 years, 4 months ago (2015-08-19 16:00:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300143002/1
5 years, 4 months ago (2015-08-19 16:04:12 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:50:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200833

Powered by Google App Engine
This is Rietveld 408576698