Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1300113006: Fixed AXLayoutObject::getSelection() so that it doesn't return nullptr for anchor and focus objects. (Closed)

Created:
5 years, 4 months ago by nektarios
Modified:
5 years, 4 months ago
CC:
aboxhall, blink-reviews, dmazzoni, je_julie
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixed AXLayoutObject::getSelection() so that it doesn't return nullptr for anchor and focus objects. BUG=491027 R=dtseng@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nektarios
5 years, 4 months ago (2015-08-20 17:44:42 UTC) #1
David Tseng
lgtm It would be great once this merges into Chrome, to add a test perhaps ...
5 years, 4 months ago (2015-08-20 18:00:43 UTC) #2
David Tseng
On 2015/08/20 18:00:43, David Tseng wrote: > lgtm > > It would be great once ...
5 years, 4 months ago (2015-08-20 18:02:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300113006/1
5 years, 4 months ago (2015-08-20 18:15:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90780)
5 years, 4 months ago (2015-08-20 18:25:15 UTC) #7
nektarios
On 2015/08/20 at 18:25:15, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
5 years, 4 months ago (2015-08-20 18:31:31 UTC) #9
dmazzoni
lgtm
5 years, 4 months ago (2015-08-20 18:43:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300113006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300113006/1
5 years, 4 months ago (2015-08-20 18:43:30 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 00:24:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200941

Powered by Google App Engine
This is Rietveld 408576698