src/scopes.cc - Issue 1300103005: [parser] disallow language mode directive in body of function with non-simple parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopes.cc

Issue 1300103005: [parser] disallow language mode directive in body of function with non-simple parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: flag implications don't work in test suite? Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/scopes.cc

diff --git a/src/scopes.cc b/src/scopes.cc

index 8c99044e72b57a659ad49953331d04e129d62dac..0c8f2106802e4c8a6bab07d9ec132243198f95ce 100644

--- a/src/scopes.cc

+++ b/src/scopes.cc

@@ -475,7 +475,6 @@ Variable* Scope::DeclareParameter(

Variable* var;

if (mode == TEMPORARY) {

var = NewTemporary(name);

- has_simple_parameters_ = false;

} else {

var = variables_.Declare(this, name, mode, Variable::NORMAL,

kCreatedInitialized);

@@ -489,7 +488,6 @@ Variable* Scope::DeclareParameter(

DCHECK_NULL(rest_parameter_);

rest_parameter_ = var;

rest_index_ = num_parameters();

- has_simple_parameters_ = false;

}

params_.Add(var, zone());

return var;

« no previous file with comments | « src/scopes.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »