Issue 13001002: remove GetTable* APIs from SkFontHost, and rely on SkTypeface::onGetTable*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13001002: remove GetTable* APIs from SkFontHost, and rely on SkTypeface::onGetTable* (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

remove GetTable* APIs from SkFontHost, and rely on SkTypeface::onGetTable* default impls call SkFontStream, and rely on SkTypeface::onOpenStream Committed: https://code.google.com/p/skia/source/detail?r=8310

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -157 lines)			Patch
M	trunk/gyp/ports.gyp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/include/core/SkFontHost.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	trunk/src/core/SkTypeface.cpp	View	2 chunks	+22 lines, -7 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_fontconfig.cpp	View	2 chunks	+1 line, -25 lines	0 comments	Download
M	trunk/src/ports/SkFontHost_mac.cpp	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	trunk/src/ports/SkFontHost_tables.cpp	View	1 chunk	+0 lines, -56 lines	0 comments	Download
M	trunk/src/ports/SkHarfBuzzFont.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 9 months ago (2013-03-21 20:34:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8310 (presubmit successful).

Expand Messages | Collapse Messages