Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: Source/core/events/CustomEvent.idl

Issue 1300093003: [bindings] Make all CustomEvent.initCustomEvent arguments non-optional and remove custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/CustomEvent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/CustomEvent.idl
diff --git a/Source/core/events/CustomEvent.idl b/Source/core/events/CustomEvent.idl
index 4d4cb085c639989686d3f31d2cb996645c8f84df..5e6d7abd36049c1f94cae0be83e1847462b91137 100644
--- a/Source/core/events/CustomEvent.idl
+++ b/Source/core/events/CustomEvent.idl
@@ -31,9 +31,5 @@
] interface CustomEvent : Event {
[Custom=Getter] readonly attribute any detail;
- // FIXME: initCustomEvent()'s arguments should not be optional.
- [Custom, Measure] void initCustomEvent([Default=Undefined] optional DOMString type,
- [Default=Undefined] optional boolean bubbles,
- [Default=Undefined] optional boolean cancelable,
- [Default=Undefined] optional any detail);
+ [Measure] void initCustomEvent(DOMString type, boolean bubbles, boolean cancelable, any detail);
};
« no previous file with comments | « Source/core/events/CustomEvent.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698