Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300093002: Change security panel overview to support neutral icons. (Closed)

Created:
5 years, 4 months ago by lgarron
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change security panel overview to to use neutral icons. BUG=522274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200869

Patch Set 1 : Add .gypi change. #

Patch Set 2 : Add .gypi change. #

Patch Set 3 : Optimize .png files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
D Source/devtools/front_end/Images/securityStateHttp.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/securityStateHttp_2x.png View Binary file 0 comments Download
A Source/devtools/front_end/Images/securityStateNeutral.png View 1 2 Binary file 0 comments Download
A Source/devtools/front_end/Images/securityStateNeutral_2x.png View 1 2 Binary file 0 comments Download
M Source/devtools/front_end/security/lockIcon.css View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lgarron
pfeldman@: Would you mind reviewing? This is a follow-up to yesterday's CLs to align the ...
5 years, 4 months ago (2015-08-19 20:45:57 UTC) #2
pfeldman
lgtm. Please make sure you run optimize_png_images on those.
5 years, 4 months ago (2015-08-19 20:49:41 UTC) #3
lgarron
I actually never ran any of the security state icons through an optimizer (this CL ...
5 years, 4 months ago (2015-08-19 20:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093002/40001
5 years, 4 months ago (2015-08-19 20:57:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95594)
5 years, 4 months ago (2015-08-19 22:56:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300093002/40001
5 years, 4 months ago (2015-08-19 22:57:07 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 01:12:26 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200869

Powered by Google App Engine
This is Rietveld 408576698