Source/core/fetch/CrossOriginAccessControl.h - Issue 1300083002: Add suggestion to use "no-cors" with Fetch fails CORS check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/CrossOriginAccessControl.h

Issue 1300083002: Add suggestion to use "no-cors" with Fetch fails CORS check. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update case where header is present but not for the correct origin. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/fetch/chromium/error-messages-expected.txt ('k') | Source/core/fetch/CrossOriginAccessControl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fetch/CrossOriginAccessControl.h

diff --git a/Source/core/fetch/CrossOriginAccessControl.h b/Source/core/fetch/CrossOriginAccessControl.h

index de062d0acbf59589e2666aeb35a3757c7edd701b..cb6c9c17683285335d0274d3e1b27bcfcb0d5511 100644

--- a/Source/core/fetch/CrossOriginAccessControl.h

+++ b/Source/core/fetch/CrossOriginAccessControl.h

@@ -59,7 +59,7 @@ CORE_EXPORT bool isOnAccessControlResponseHeaderWhitelist(const String&);

void updateRequestForAccessControl(ResourceRequest&, SecurityOrigin*, StoredCredentials);

ResourceRequest createAccessControlPreflightRequest(const ResourceRequest&, SecurityOrigin*);

-bool passesAccessControlCheck(const ResourceResponse&, StoredCredentials, SecurityOrigin*, String& errorDescription);

+bool passesAccessControlCheck(const ResourceResponse&, StoredCredentials, SecurityOrigin*, String& errorDescription, WebURLRequest::RequestContext requestType);

sof 2015/09/09 05:22:04 Can we try to follow http://google-styleguide.goog

bool passesPreflightStatusCheck(const ResourceResponse&, String& errorDescription);

CORE_EXPORT void parseAccessControlExposeHeadersAllowList(const String& headerValue, HTTPHeaderSet&);