Added tests for docs.dart

tools/dom/docs/lib/docs.dart

+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
 /**
  * A library for extracting the documentation from the various HTML libraries
  * ([dart:html], [dart:svg], [dart:web_audio], [dart:indexed_db]) and saving
  * those documentation comments to a JSON file.
  */
 
 library docs;
 
 import '../../../../sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart';
 import '../../../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart';
@@ skipping 37 matching lines @@
  */
 Future<bool> convert(Path libPath, Path jsonPath) {
   var paths = <Path>[];
   for (var libraryName in HTML_LIBRARY_NAMES) {
     paths.add(new Path(libraryName));
   }
 
   return analyze(paths, libPath, options: ['--preserve-comments'])
     .then((MirrorSystem mirrors) {
       var convertedJson = _generateJsonFromLibraries(mirrors);
-      return new Future.immediate(_exportJsonToFile(convertedJson, jsonPath));
+      return _exportJsonToFile(convertedJson, jsonPath);
     });
 }
 
-bool _exportJsonToFile(Map convertedJson, Path jsonPath) {
+Future<bool> _exportJsonToFile(Map convertedJson, Path jsonPath) {

[Bob Nystrom, 2013/03/28 14:18:40]

This method does both sync and async IO, which means it could both throw a
runtime exception or complete to one. We prefer having functions that return
futures to report all runtime errors through the future. The simple fix is to
wrap the sync IO in a future:

return Future.of(() {
  final jsonFile...
  ...
  return outputSream.done...
});

[Andrei Mouravski, 2013/03/28 17:01:14]

Done.

   final jsonFile = new File.fromPath(jsonPath);
   var writeJson = prettySerialize(convertedJson);
 
   var outputStream = jsonFile.openWrite();
   outputStream.writeln(writeJson);
-
-  return false;
+  outputStream.close();
+  return outputStream.done.then((_) => false);
 }
 
 Map _generateJsonFromLibraries(MirrorSystem mirrors) {
   var convertedJson = {};
 
   // Sort the libraries by name (not key).
   var sortedLibraries = new List<LibraryMirror>.from(
       mirrors.libraries.values.where(
           (e) => HTML_LIBRARY_NAMES.indexOf(e.uri.toString()) >= 0))
       ..sort((x, y) =>
@@ skipping 97 matching lines @@
     for (var s in tags.reflectee.split(',')) {
       domNames.add(s.trim());
     }
 
     if (domNames.length == 1 && domNames[0] == 'none') return <String>[];
     return domNames;
   } else {
     return <String>[];
   }
 }