Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Issue 1299993004: sort errors so they appear in stable order (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

sort errors so they appear in stable order should be the same order analyzer_cli uses R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6772cc7687f116fbcba82c552aab25a041050a94

Patch Set 1 : #

Patch Set 2 : remove fixed TODO #

Patch Set 3 : fix html messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -516 lines) Patch
M lib/src/compiler.dart View 1 2 6 chunks +16 lines, -9 lines 0 comments Download
M lib/src/report.dart View 1 1 chunk +51 lines, -11 lines 0 comments Download
M test/codegen/expect/js_test.txt View 2 chunks +296 lines, -296 lines 0 comments Download
M tool/sdk_expected_errors.txt View 6 chunks +200 lines, -200 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
5 years, 4 months ago (2015-08-19 23:48:17 UTC) #4
vsm
lgtm - thanks!
5 years, 4 months ago (2015-08-20 13:35:33 UTC) #5
Jennifer Messerly
5 years, 4 months ago (2015-08-20 15:59:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as
6772cc7687f116fbcba82c552aab25a041050a94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698