Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: pdfium.gyp

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 'variables': { 2 'variables': {
3 'pdf_use_skia%': 0, 3 'pdf_use_skia%': 0,
4 'conditions': [ 4 'conditions': [
5 ['OS=="linux"', { 5 ['OS=="linux"', {
6 'bundle_freetype%': 0, 6 'bundle_freetype%': 0,
7 }, { # On Android there's no system FreeType. On Windows and Mac, only a 7 }, { # On Android there's no system FreeType. On Windows and Mac, only a
8 # few methods are used from it. 8 # few methods are used from it.
9 'bundle_freetype%': 1, 9 'bundle_freetype%': 1,
10 }], 10 }],
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 'ldflags': [ '-L<(PRODUCT_DIR)',], 310 'ldflags': [ '-L<(PRODUCT_DIR)',],
311 'sources': [ 311 'sources': [
312 'core/include/fpdftext/fpdf_text.h', 312 'core/include/fpdftext/fpdf_text.h',
313 'core/src/fpdftext/fpdf_text.cpp', 313 'core/src/fpdftext/fpdf_text.cpp',
314 'core/src/fpdftext/fpdf_text_int.cpp', 314 'core/src/fpdftext/fpdf_text_int.cpp',
315 'core/src/fpdftext/fpdf_text_search.cpp', 315 'core/src/fpdftext/fpdf_text_search.cpp',
316 'core/src/fpdftext/text_int.h', 316 'core/src/fpdftext/text_int.h',
317 'core/src/fpdftext/txtproc.h', 317 'core/src/fpdftext/txtproc.h',
318 'core/src/fpdftext/unicodenormalization.cpp', 318 'core/src/fpdftext/unicodenormalization.cpp',
319 'core/src/fpdftext/unicodenormalizationdata.cpp', 319 'core/src/fpdftext/unicodenormalizationdata.cpp',
320 'core/src/fpdftext/unicodenormalizationdata.h',
320 ], 321 ],
321 }, 322 },
322 { 323 {
323 'target_name': 'fxcodec', 324 'target_name': 'fxcodec',
324 'type': 'static_library', 325 'type': 'static_library',
325 'dependencies': [ 326 'dependencies': [
326 'third_party/third_party.gyp:fx_lcms2', 327 'third_party/third_party.gyp:fx_lcms2',
327 'third_party/third_party.gyp:fx_libjpeg', 328 'third_party/third_party.gyp:fx_libjpeg',
328 'third_party/third_party.gyp:fx_libopenjpeg', 329 'third_party/third_party.gyp:fx_libopenjpeg',
329 'third_party/third_party.gyp:fx_zlib', 330 'third_party/third_party.gyp:fx_zlib',
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 'core/src/fxge/apple/apple_int.h', 465 'core/src/fxge/apple/apple_int.h',
465 'core/src/fxge/apple/fx_apple_platform.cpp', 466 'core/src/fxge/apple/fx_apple_platform.cpp',
466 'core/src/fxge/apple/fx_mac_imp.cpp', 467 'core/src/fxge/apple/fx_mac_imp.cpp',
467 'core/src/fxge/apple/fx_quartz_device.cpp', 468 'core/src/fxge/apple/fx_quartz_device.cpp',
468 'core/src/fxge/dib/dib_int.h', 469 'core/src/fxge/dib/dib_int.h',
469 'core/src/fxge/dib/fx_dib_composite.cpp', 470 'core/src/fxge/dib/fx_dib_composite.cpp',
470 'core/src/fxge/dib/fx_dib_convert.cpp', 471 'core/src/fxge/dib/fx_dib_convert.cpp',
471 'core/src/fxge/dib/fx_dib_engine.cpp', 472 'core/src/fxge/dib/fx_dib_engine.cpp',
472 'core/src/fxge/dib/fx_dib_main.cpp', 473 'core/src/fxge/dib/fx_dib_main.cpp',
473 'core/src/fxge/dib/fx_dib_transform.cpp', 474 'core/src/fxge/dib/fx_dib_transform.cpp',
475 'core/src/fxge/fontdata/chromefontdata/chromefontdata.h',
474 'core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c', 476 'core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c',
475 'core/src/fxge/fontdata/chromefontdata/FoxitFixed.c', 477 'core/src/fxge/fontdata/chromefontdata/FoxitFixed.c',
476 'core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c', 478 'core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c',
477 'core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c', 479 'core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c',
478 'core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c', 480 'core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c',
479 'core/src/fxge/fontdata/chromefontdata/FoxitSans.c', 481 'core/src/fxge/fontdata/chromefontdata/FoxitSans.c',
480 'core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c', 482 'core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c',
481 'core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c', 483 'core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c',
482 'core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c', 484 'core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c',
483 'core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c', 485 'core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c',
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 'testing/embedder_test.cpp', 756 'testing/embedder_test.cpp',
755 'testing/embedder_test.h', 757 'testing/embedder_test.h',
756 'testing/embedder_test_mock_delegate.h', 758 'testing/embedder_test_mock_delegate.h',
757 'testing/embedder_test_timer_handling_delegate.h', 759 'testing/embedder_test_timer_handling_delegate.h',
758 'testing/fx_string_testhelpers.cpp', 760 'testing/fx_string_testhelpers.cpp',
759 'testing/fx_string_testhelpers.h', 761 'testing/fx_string_testhelpers.h',
760 ], 762 ],
761 }, 763 },
762 ], 764 ],
763 } 765 }
OLDNEW
« core/src/fpdftext/unicodenormalization.cpp ('K') | « fpdfsdk/src/javascript/global.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698