core/src/fxge/fontdata/chromefontdata/FoxitSerif.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSerif.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSerifBold.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSerifFontData [19469] = {0x1,	9 const unsigned char g_FoxitSerifFontData [19469] = {0x1,

8 0x0, 0x4, 0x2, 0x0, 0x1, 0x1 , 0x1, 0xe,	10 0x0, 0x4, 0x2, 0x0, 0x1, 0x1 , 0x1, 0xe,

9 0x43, 0x68, 0x72, 0x6f, 0x6d , 0x53, 0x65, 0x72,	11 0x43, 0x68, 0x72, 0x6f, 0x6d , 0x53, 0x65, 0x72,

10 0x69, 0x66, 0x4f, 0x54, 0x46 , 0x0, 0x1, 0x1,	12 0x69, 0x66, 0x4f, 0x54, 0x46 , 0x0, 0x1, 0x1,

11 0x1, 0x26, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1,	13 0x1, 0x26, 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1,

12 0xf8, 0x1d, 0x2, 0xf8, 0x1d, 0x3, 0xf8, 0x18,	14 0xf8, 0x1d, 0x2, 0xf8, 0x1d, 0x3, 0xf8, 0x18,

13 0x4, 0xfb, 0x3c, 0xfb, 0x8e, 0xfa, 0x7c, 0xfa,	15 0x4, 0xfb, 0x3c, 0xfb, 0x8e, 0xfa, 0x7c, 0xfa,

14 0x2, 0x5, 0x1c, 0x7, 0x9f, 0 xf, 0x1c, 0x8,	16 0x2, 0x5, 0x1c, 0x7, 0x9f, 0 xf, 0x1c, 0x8,

15 0xf6, 0x11, 0xb6, 0x1c, 0x44 , 0xa3, 0x12, 0x0,	17 0xf6, 0x11, 0xb6, 0x1c, 0x44 , 0xa3, 0x12, 0x0,

16 0x3, 0x1, 0x1, 0x5, 0x2f, 0x 3e, 0x45, 0x75,	18 0x3, 0x1, 0x1, 0x5, 0x2f, 0x 3e, 0x45, 0x75,

(...skipping 2416 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2433 0xf8, 0xa4, 0x76, 0xf7, 0x3b , 0x77, 0x1, 0xb,	2435 0xf8, 0xa4, 0x76, 0xf7, 0x3b , 0x77, 0x1, 0xb,

2434 0xf7, 0xf, 0xfb, 0x34, 0x76, 0xf9, 0xf1, 0x77,	2436 0xf7, 0xf, 0xfb, 0x34, 0x76, 0xf9, 0xf1, 0x77,

2435 0xb, 0xa9, 0xaf, 0xaf, 0xa9, 0x6d, 0x67, 0x67,	2437 0xb, 0xa9, 0xaf, 0xaf, 0xa9, 0x6d, 0x67, 0x67,

2436 0x6d, 0xb, 0x8f, 0x7b, 0x1b, 0x6c, 0x8a, 0x81,	2438 0x6d, 0xb, 0x8f, 0x7b, 0x1b, 0x6c, 0x8a, 0x81,

2437 0x1d, 0xb, 0x7b, 0x69, 0x29, 0x78, 0xe2, 0xc0,	2439 0x1d, 0xb, 0x7b, 0x69, 0x29, 0x78, 0xe2, 0xc0,

2438 0x7f, 0x1e, 0xb, 0xfb, 0x6e, 0xdf, 0x37, 0xf1,	2440 0x7f, 0x1e, 0xb, 0xfb, 0x6e, 0xdf, 0x37, 0xf1,

2439 0xb, 0xf7, 0x54, 0xfb, 0x41, 0x77, 0xb, 0x1a,	2441 0xb, 0xf7, 0x54, 0xfb, 0x41, 0x77, 0xb, 0x1a,

2440 0xfb, 0x38, 0x7, 0xb, 0x72, 0x6b, 0x1e, 0xb,	2442 0xfb, 0x38, 0x7, 0xb, 0x72, 0x6b, 0x1e, 0xb,

2441 0xf7, 0x6, 0x3, 0xb	2443 0xf7, 0x6, 0x3, 0xb

2442 };	2444 };

OLD	NEW