core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/src/fpdftext/unicodenormalization.cpp ('K') | « core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c ('k') | core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitSansItalicFontData [16339] = {0x1,	9 const unsigned char g_FoxitSansItalicFontData [16339] = {0x1,

8 0x0, 0x4, 0x2, 0x0, 0x1 , 0x1, 0x1, 0x14,	10 0x0, 0x4, 0x2, 0x0, 0x1 , 0x1, 0x1, 0x14,

9 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x61, 0x6e,	11 0x43, 0x68, 0x72, 0x6f, 0x6d, 0x53, 0x61, 0x6e,

10 0x73, 0x4f, 0x54, 0x46, 0x2d, 0x49, 0x74, 0x61,	12 0x73, 0x4f, 0x54, 0x46, 0x2d, 0x49, 0x74, 0x61,

11 0x6c, 0x69, 0x63, 0x0, 0x1, 0x1, 0x1, 0x27,	13 0x6c, 0x69, 0x63, 0x0, 0x1, 0x1, 0x1, 0x27,

12 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8, 0x1d,	14 0xf8, 0x10, 0x0, 0xf8, 0x1c, 0x1, 0xf8, 0x1d,

13 0x2, 0xf8, 0x1e, 0x3, 0 xf8, 0x18, 0x4, 0x7f,	15 0x2, 0xf8, 0x1e, 0x3, 0 xf8, 0x18, 0x4, 0x7f,

14 0xc, 0x2, 0xfb, 0x3e, 0 xfb, 0x75, 0xfa, 0xf0,	16 0xc, 0x2, 0xfb, 0x3e, 0 xfb, 0x75, 0xfa, 0xf0,

15 0xfa, 0x4b, 0x5, 0xf7, 0x36, 0xf, 0xf9, 0x1,	17 0xfa, 0x4b, 0x5, 0xf7, 0x36, 0xf, 0xf9, 0x1,

16 0x11, 0xc3, 0x1c, 0x3a, 0xfc, 0x12, 0x0, 0x4,	18 0x11, 0xc3, 0x1c, 0x3a, 0xfc, 0x12, 0x0, 0x4,

(...skipping 2025 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2042 0x84, 0xd4, 0x1, 0xbe, 0xf7, 0x84, 0x15, 0xb,	2044 0x84, 0xd4, 0x1, 0xbe, 0xf7, 0x84, 0x15, 0xb,

2043 0xf8, 0xac, 0x8d, 0x76, 0xa8, 0x76, 0xd2, 0xc1,	2045 0xf8, 0xac, 0x8d, 0x76, 0xa8, 0x76, 0xd2, 0xc1,

2044 0xb, 0x6, 0xa3, 0x90, 0 x96, 0x9c, 0xb, 0xf6,	2046 0xb, 0x6, 0xa3, 0x90, 0 x96, 0x9c, 0xb, 0xf6,

2045 0x4c, 0xa, 0xb, 0xf4, 0 xef, 0xf8, 0x9d, 0xef,	2047 0x4c, 0xa, 0xb, 0xf4, 0 xef, 0xf8, 0x9d, 0xef,

2046 0xb, 0x6, 0x7d, 0x87, 0 x85, 0x72, 0xb, 0x6,	2048 0xb, 0x6, 0x7d, 0x87, 0 x85, 0x72, 0xb, 0x6,

2047 0x9c, 0xdf, 0x5, 0xb, 0 x6, 0x9d, 0xdc, 0x5,	2049 0x9c, 0xdf, 0x5, 0xb, 0 x6, 0x9d, 0xdc, 0x5,

2048 0xb, 0xf8, 0x74, 0x78, 0xdc, 0xb, 0xf7, 0x21,	2050 0xb, 0xf8, 0x74, 0x78, 0xdc, 0xb, 0xf7, 0x21,

2049 0x5, 0xb, 0x15, 0xe6, 0 x6, 0xb, 0xf7, 0x1f,	2051 0x5, 0xb, 0x15, 0xe6, 0 x6, 0xb, 0xf7, 0x1f,

2050 0x5, 0xb	2052 0x5, 0xb

2051 };	2053 };

OLD	NEW