core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

	7 #include "chromefontdata.h"

	8

7 const unsigned char g_FoxitDingbatsFontData [29513] = {0x1,	9 const unsigned char g_FoxitDingbatsFontData [29513] = {0x1,

8 0x0, 0x4, 0x2, 0x0, 0x1, 0x1, 0x1, 0x11,	10 0x0, 0x4, 0x2, 0x0, 0x1, 0x1, 0x1, 0x11,

9 0x43, 0x68, 0x72, 0x6f, 0 x6d, 0x44, 0x69, 0x6e,	11 0x43, 0x68, 0x72, 0x6f, 0 x6d, 0x44, 0x69, 0x6e,

10 0x67, 0x62, 0x61, 0x74, 0 x73, 0x4f, 0x54, 0x46,	12 0x67, 0x62, 0x61, 0x74, 0 x73, 0x4f, 0x54, 0x46,

11 0x0, 0x1, 0x1, 0x1, 0x25, 0xf8, 0x10, 0x0,	13 0x0, 0x1, 0x1, 0x1, 0x25, 0xf8, 0x10, 0x0,

12 0xf8, 0xe4, 0x1, 0xf8, 0x e5, 0x2, 0xf8, 0xe5,	14 0xf8, 0xe4, 0x1, 0xf8, 0x e5, 0x2, 0xf8, 0xe5,

13 0x3, 0xf8, 0xe6, 0x4, 0x8 a, 0xfb, 0x38, 0xfa,	15 0x3, 0xf8, 0xe6, 0x4, 0x8 a, 0xfb, 0x38, 0xfa,

14 0x69, 0xf9, 0xce, 0x5, 0x 1c, 0x4, 0xdc, 0xf,	16 0x69, 0xf9, 0xce, 0x5, 0x 1c, 0x4, 0xdc, 0xf,

15 0x1c, 0x4, 0xe3, 0x11, 0x a7, 0x1c, 0x6e, 0x3f,	17 0x1c, 0x4, 0xe3, 0x11, 0x a7, 0x1c, 0x6e, 0x3f,

16 0x12, 0x0, 0xcc, 0x2, 0x0 , 0x1, 0x0, 0x3,	18 0x12, 0x0, 0xcc, 0x2, 0x0 , 0x1, 0x0, 0x3,

(...skipping 3671 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
3688 0x89, 0x81, 0x5b, 0x73, 0 xa4, 0xa8, 0x69, 0xb,	3690 0x89, 0x81, 0x5b, 0x73, 0 xa4, 0xa8, 0x69, 0xb,

3689 0x15, 0x9b, 0x7b, 0x9d, 0 x82, 0x90, 0x90, 0x90,	3691 0x15, 0x9b, 0x7b, 0x9d, 0 x82, 0x90, 0x90, 0x90,

3690 0x90, 0xb, 0x15, 0x90, 0x 86, 0x9d, 0x94, 0x9b,	3692 0x90, 0xb, 0x15, 0x90, 0x 86, 0x9d, 0x94, 0x9b,

3691 0x9b, 0x9b, 0x9b, 0xb, 0x 3, 0xae, 0x16, 0xb,	3693 0x9b, 0x9b, 0x9b, 0xb, 0x 3, 0xae, 0x16, 0xb,

3692 0x9a, 0x85, 0x97, 0x1e, 0 x82, 0x9d, 0x80, 0x98,	3694 0x9a, 0x85, 0x97, 0x1e, 0 x82, 0x9d, 0x80, 0x98,

3693 0xb, 0x99, 0x8b, 0xf7, 0x 2, 0x3e, 0xb7, 0xac,	3695 0xb, 0x99, 0x8b, 0xf7, 0x 2, 0x3e, 0xb7, 0xac,

3694 0x99, 0xb, 0xfb, 0xad, 0x 5, 0xf7, 0x35, 0x7,	3696 0x99, 0xb, 0xfb, 0xad, 0x 5, 0xf7, 0x35, 0x7,

3695 0xe, 0x13, 0x94, 0x54, 0x ec, 0x1b, 0xb, 0x1f,	3697 0xe, 0x13, 0x94, 0x54, 0x ec, 0x1b, 0xb, 0x1f,

3696 0x8d, 0x8d, 0x5, 0xb, 0x5 , 0x89, 0x7, 0xb	3698 0x8d, 0x8d, 0x5, 0xb, 0x5 , 0x89, 0x7, 0xb

3697 };	3699 };

OLD	NEW