core/src/fpdftext/unicodenormalizationdata.h - Issue 1299963002: Extern in .cpp files is a code smell.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fpdftext/unicodenormalizationdata.h

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

	6

	7 #ifndef CORE_SRC_FPDFTEXT_UNICODENORMALIZATIONDATA_H_

	8 #define CORE_SRC_FPDFTEXT_UNICODENORMALIZATIONDATA_H_

	9

	10 #include "../../include/fxcrt/fx_system.h"

	11

	12 extern const FX_WCHAR g_UnicodeData_Normalization[];

	13 extern const FX_WCHAR g_UnicodeData_Normalization_Map1[];

	14 extern const FX_WCHAR g_UnicodeData_Normalization_Map2[];

	15 extern const FX_WCHAR g_UnicodeData_Normalization_Map3[];

	16 extern const FX_WCHAR g_UnicodeData_Normalization_Map4[];

	17

	18 #endif // CORE_SRC_FPDFTEXT_UNICODENORMALIZATIONDATA_H_

OLD	NEW